littlebizzy / hovercraft

No maintenance WordPress theme

HoverCraft

No maintenance WordPress theme

Changelog

0.2.x

• still a little bit alpha
• forced update (fixes versioning conflict)
• passes Theme Check basic tests

0.1.x

• alpha branch
• more messing around

0.0.x

• support for Git Updater
• messing around

hovercraft's Issues

Sidebar callout widget CSS specificity issues

This bug report contains two separate issues, but they're kind of related so I thought I'd report them together.

When I look at the sidebar on the HoverCraft website (example: https://hovercraft.vip/philosophy/), the button has the same color for both the text and the background.

The sidebar on the SlickStack website (example: https://slickstack.io/about) has a similar but slightly different problem. At first the button appears to be working fine.

However, when I hover the mouse over the button, the background color becomes the same as the text color. (Note that screenshots on Windows apparently do not capture the mouse pointer, but the screenshot was taken with the mouse pointer hovering over the button.)

The problem in both cases appears to be that the sidebar CSS rules have higher specificity than the button's own CSS rules. I'm not sure what is the best way to fix this, but there's a couple of new(ish) CSS features that may be helpful here:

1. The :where pseudo-class

2. Cascade layers

404 "Not Found" page

If you visit a URL which does not exist, HoverCraft just displays the text "Last modified on".

Admin URLs should use `admin_url()`

This issue is kind of similar to issue #28 in that it will only affect sites where WordPress is installed in a subdirectory (e.g., https://example.com/example/).

In inc/media-sizes-verify.php a URL is hard-coded: <a href="/wp-admin/options-media.php">Review Settings</a>. This link will be broken if WordPress is located in a subdirectory.

It should be <a href="<?php echo esc_url( admin_url( 'options-media.php' ) ); ?>">Review Settings</a>.

JQMIGRATE: jQuery.fn.focus() event shorthand is deprecated

If you define SCRIPT_DEBUG as TRUE and then click the search icon, the following warning gets displayed in the browser console:

JQMIGRATE: jQuery.fn.focus() event shorthand is deprecated

This is coming from assets/js/full-screen-search.js

There are a couple of ways this could be fixed:

1. The simplest thing to do would be to just follow the advice at https://api.jquery.com/focus-shorthand/ and make this change:

   Instead of .focus(), use .trigger( "focus" ).

2. Another possibility would be to use the native focus() method instead. In fact, it might be worthwhile to consider removing jQuery entirely, since that would improve performance. (Actually, in practice it would probably not improve performance much, but it would improve HoverCraft's Google PageSpeed score, and for most people that is all that matters in life.)

Mobile menu appears below WordPress admin bar

When the user is logged in to WordPress, the mobile menu (id="myNav", with z-index 9999) appears below the WordPress admin bar (id="wpadminbar", with z-index 99999).

I would suggest increasing the z-index of the myNav element to something greater than 99999 so that it appears above the admin bar.

`home_url()` and `get_home_url()` should be called with `'/'` argument

There are a few places in the code where home_url() and get_home_url() are called without any arguments. These should be home_url( '/' ) and get_home_url( null, '/' ) respectively (or for simplicity just use home_url( '/' ) everywhere).

Calling home_url() or get_home_url() without arguments will output a URL without a trailing slash. For most WordPress sites this will not actually make any difference, but for sites where WordPress is installed in a subdirectory, the result will be a URL that looks like https://example.com/example - this will issue a 301 redirect to https://example.com/example/ instead of rendering the home page directly.

See https://github.com/Automattic/_s/blob/master/header.php for an example of using home_url( '/' ).

Undefined variable: premain_top_link_decoration (and others)

I'm seeing some notices (with WP_DEBUG set to true):

PHP Notice:  Undefined variable: premain_top_link_decoration in .../hovercraft/inc/css-generator.php on line 2422
PHP Notice:  Undefined variable: premain_bottom_link_decoration in .../hovercraft/inc/css-generator.php on line 2449
PHP Notice:  Undefined variable: postmain_top_link_decoration in .../hovercraft/inc/css-generator.php on line 2476
PHP Notice:  Undefined variable: postmain_bottom_link_decoration in .../hovercraft/inc/css-generator.php on line 2503

Full screen search close button has `visibility: visible`

When testing the full screen search, I noticed that it was difficult to click on the search icon - sometimes clicks would have no effect depending on where exactly the mouse was clicked.

Inspecting the HTML/CSS, I see that the full screen search close button is always being rendered on the page, even when the search overlay is not being displayed. It can't actually be seen because it has zero opacity, but it has visibility: visible and is still able to receive mouse clicks and block clicks on elements underneath.

Ironically the thing it ends up covering is the search icon, but that is just a coincidence (also this will probably vary depending on your layout settings).

$post bug

bug at:

hovercraft/inc/css-generator.php

Line 7 in 4ffa85d

$url_featured_image = wp_get_attachment_url( get_post_thumbnail_id($post->ID), 'large' );

error log:

cart

cart widget is currently on menu-desktop. (template-parts/navigation.php)
this is not desirable since it is needed on desktop as well.
i moved it to header-right offline but its not ready for production yet. it needs padding etc.
will commit once ready.

minor css issue

minor styling issue as seen on:

arrow position is all over the place.

Missing the files

Hi Jesse,

Starter (a truly lean self-contained theme with no parent or child relationships) is a great idea. You've sold me. But while there's a demo site there's no files there or here.

Any chance you could share them even in an imperfect state with a world eager for a better WordPress?

Cordial regards,

Alec