lit-protocol / ceramicintegration Goto Github PK

In yarn.lock:
web-streams-polyfill@https://github.com/gwicke/web-streams-polyfill#spec_performance_improvements is being fetched with git:// (ssh) instead of https://

yarn install v1.22.19
[1/4] Resolving packages...
[2/4] Fetching packages...
error Command failed.
Exit code: 128
Command: git
Arguments: ls-remote --tags --heads git://github.com/gwicke/web-streams-polyfill
Directory: C:\Users\rsasdasd\Projects\CeramicIntegration
Output:
fatal: unable to connect to github.com:
github.com[0: 140.82.113.4]: errno=Unknown error

There's much less a guarantee of ssh than https:// suggest you change or state a dependency in the readme of ssh on command line.

In encryptAndWrite function, errors during the encrypting & writing process are all caught, and returned as string.

https://github.com/LIT-Protocol/CeramicIntegration/blob/main/src/integration.ts#L71

However, this behavior is confusing because the document says that the return value of this function is the created stream ID.

How about just throwing error when error occurs? It would reduce confusion, and also would help developers easily debug their apps.

(fyi: we use this function in our app, we had to write a bit ugly error handling due to this behavior.)

Reading a stream in Ceramic does not need authentication.

However, in the "readAndDecrypt" function, authentication to Ceramic is always performed.
So, even if users just want to read data, they have to create (or choose) their DIDs for authentication, which is not good for UX.

How about removing the authentication?

The description comment for function _readCeramic in ceramic.ts file is wrong.

Currently, the integration works if you're trying to encrypt a strong and store it on ceramic and gate it using Lit.

Could we add the relevant functions that also encrypt a file and then store the encrypted file contents on ceramic?

I'm trying to use this package, but encountered issues with webpack while building.
Also, I'm no bundling expert, so I'd like to get help in troubleshooting

Steps to reproduce

Note, both ways yield different errors, but underlying problem should be the same, and relates to

You should not need to recompile .ts files there, but if you really want to, use the allowTsInNodeModules option.
See: microsoft/TypeScript#12358
Edit: hmm, not sure anymore about this one

Quickest way it to use

1. https://github.com/LIT-Protocol/CeramicIntegrationExample
2. yarn
3. yarn watch
4. Error log

ERROR in ./node_modules/lit-ceramic-sdk/integration.ts 3:12
Module parse failed: Unexpected token (3:12)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
| // Don't forget to rebuild
| import { createIDX } from "./idx";
> import type { CeramicApi } from "@ceramicnetwork/common";
| import { _encryptWithLit, _decryptWithLit } from "./lit";
| import { _startLitClient } from "./client";
@ ./node_modules/lit-ceramic-sdk/index.ts 3:0-44 5:0-23
@ ./src/app.ts

Other

1. Have webpack based project
2. install lit-ceramic-sdk
3. build
4. Error log
   

ERROR in ./node_modules/did-jwt/lib/index.module.js 1665:17
Module parse failed: Unexpected token (1665:17)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
|               // TODO: should be able to use non base58 keys too
|               return key.type === 'X25519KeyAgreementKey2019' && Boolean(key.publicKeyBase58);
>             })) ?? [];
|             if (!pks.length && !controllerEncrypters.length) throw new Error(`no_suitable_keys: Could not find x25519 key for ${did}`);
|             return pks.map(pk => x25519Encrypter(base58ToBytes(pk.publicKeyBase58), pk.id)).concat(...controllerEncrypters);
@ ./node_modules/dids/lib/did.js 14:18-36
@ ./node_modules/dids/lib/index.js
@ ./node_modules/lit-ceramic-sdk/ceramic.ts
@ ./node_modules/lit-ceramic-sdk/integration.ts
@ ./node_modules/lit-ceramic-sdk/index.ts

No idea why these aren't disabled by default in a dist, but please add the option to silence them.

lit-ceramic-sdk version: 1.1.13