lisiadito / join-lines-plugin Goto Github PK

Hi !
Very cool this plugin, though there is an incoherence between the doc to install the plugin and the repo.json.
You state you have to have to write > plugin install join-lines in the README.MD
But
The name of the plugin in the repo.json file is joinLines
Actually I had to write > plugin install joinLines to install the plugin.

I can make a pull request if you want, but I don't know which of the README.MD or repo.json is correct.

Can you tell me what should be the name of the plugin ?

EDIT : Actually it would be easier to change the doc, because the name joinLines is used in the plugin channel

The following link located at "repo.json" file is broken, so plugin can't be installed.

https://github.com/Lisiadito/join-lines-plugin/archive/v1.0.0.zip

If you use joinLines to join the current and the next line, it removes most of the indentation from the current line, which is probably not what you want, particularly when editing code.

So for example:

       x =
              y

becomes

 x = y

when you probably wanted

       x = y

This happens because line 38 reduces all whitespace to a single space character:

    local modifiedSelection = string.gsub(selection, "%s+", " ")

This also means that if you have deliberate whitespace within a line it gets squased eg.

x:          blah;
y:           foo
                 + bar; 

if joining the y: line to the one below you get:

x:          blah;
y: foo + bar;

Both issues can be solved by requiring the replaced whitespace to start with a new line:

    local modifiedSelection = string.gsub(selection, "\n%s+", " ")

As mentioned in #4#issuecomment-647115833, join presently stops at paragraph breaks, why not let it keep going -- as in other editors?

When I past the following into Sublime and go to the first line and hit alt-j twice, it joins the first two lines. Hitting alt-j a third time deletes the line I'm on and the next line, instead of joining them.

 The original Moore’s Law came out of an article I published in 1965 this was the
early days of the integrated circuit, we were just learning to put a few components on a chip. I was
given the chore of predicting what would happen in silicon components in the next 10 years for the
35th anniversary edition of “Electronic Magazine”