lirc572 / ip

Elaina is the ultimate personal assistant chatbot.

Hey there 🍺🍺🍺

ip's Issues

implement clear command

Sharing iP code quality feedback [for @lirc572]

We did an automated analysis of your code to detect potential areas to improve the code quality. We are sharing the results below, to help you improve the code further.

IMPORTANT: Note that the script looked for just a few easy-to-detect problems only, and at-most one example is given i.e., there can be other areas/places to improve.

Aspect: Tab Usage

No easy-to-detect issues 👍

Aspect: Brace Style

No easy-to-detect issues 👍

Aspect: Package Name Style

No easy-to-detect issues 👍

Aspect: Class Name Style

No easy-to-detect issues 👍

Aspect: Dead Code

No easy-to-detect issues 👍

Aspect: Method Length

Example from src/main/java/com/lirc572/ip/Storage.java lines 40-77:

    public static void readFromFile(TaskList tasks) {
        assert FILE_NAME.length() > 0 : "FILE_NAME cannot be empty";
        try {
            File fileObj = new File(FILE_NAME);
            fileObj.createNewFile();
            Scanner fileReader = new Scanner(fileObj);
            StringBuilder data = new StringBuilder();
            while (fileReader.hasNextLine()) {
                data.append(fileReader.nextLine() + "\n");
            }
            fileReader.close();
            String[] lines = data.toString().split("\n");
            for (String line : lines) {
                String[] sections = line.split(Pattern.quote(" | "));
                if (sections[0].equals("T")) {
                    Task task = new TodoTask(sections[2]);
                    if (sections[1].equals("1")) {
                        task.setIsDone(true);
                    }
                    tasks.add(task);
                } else if (sections[0].equals("D")) {
                    Task task = new DeadlineTask(sections[2], sections[3].equals("null") ? null : sections[3]);
                    if (sections[1].equals("1")) {
                        task.setIsDone(true);
                    }
                    tasks.add(task);
                } else if (sections[0].equals("E")) {
                    Task task = new EventTask(sections[2], sections[3].equals("null") ? null : sections[3]);
                    if (sections[1].equals("1")) {
                        task.setIsDone(true);
                    }
                    tasks.add(task);
                }
            }
        } catch (IOException e) {
            Ui.printError(e);
        }
    }

Suggestion: Consider applying SLAP (and other abstraction mechanisms) to shorten methods. You may ignore this suggestion if you think a longer method is justified in a particular case.

ℹ️ The bot account @cs2103-bot used to post this issue is un-manned. Do not reply to this post (as those replies will not be read). Instead, contact [email protected] if you want to follow up on this post.

Unicode characters become `?` when stored in file

Use FXML for GUI

^^

Add a background image

When screen resizes, the size of components in the window get messed up

It happens when changing the screen resolution and moving the window between two monitors of different resolutions.

Clickable links do not work under Ubuntu

^^

Add containers for dialog boxes

Fix `Create JAR` action

^^

Docs: add simple regex usage in user guide appendix