Coder Social home page Coder Social logo

nubank-dotnet's Issues

Do not directly depend on QRCoder library

The library is directly dependant on "QRCoder" nuget package, so the clients are locked in to this library to authenticate. A good way to avoid this is to defer QR code generation through a delegate that should be implemented by the client code, something like:

public async Task AutenticateWithQrCodeAsync(Action<Guid> printQrCode)
{
	if (string.IsNullOrEmpty(_authToken))
	{
		await GetTokenAsync();
	}
	
	printQrCode(_qrCodeId); // Calls the action passed by the caller (in the example program it could be the GetQrCodeAsAscii stuff);

	var payload = new
	{
		qr_code_id = _qrCodeId,
		type = "login-webapp"
	};

	while (!IsAuthenticated()) // Could have an attempt limit
	{
		var response = await _client.PostAsync<Dictionary<string, object>>(_endpoints.Lift, payload, GetHeaders());
                if(Succeeded(response))
                {
                       break;
                }

	        await Task.Delay(2000);              
	}

	FillTokens(response);

	FillAutenticatedUrls(response);
}

Implement caching to avoid "Too many requests" error

Hi, I was building a project to extract data from Nubank API when I found yours, which was surprisinly similar to mine. I'll go with your implementation for now on, thanks!

Here is one suggestion: Implement some caching to avoid "Too Many Requests" occuring. It could have a default configuration (e.g. cache everything for 30 minutes).

A good caching implementation using Polly:
https://github.com/App-vNext/Polly/wiki/Cache

What do you think?
I'd be glad to contribute if you're interested ๐Ÿ‘

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.