linusskucas / email-skill Goto Github PK

I made a quick package to handle monitoring email

consider using https://github.com/JarbasAl/mail_monitor

see https://community.mycroft.ai/t/testing-and-feedback-email-commands-skill/9417 for a different skill using it

also allows you to read the content of the email, first step to solve #12

supports a sender whitelist, which allows solving #4

I have two Gmail inboxes and one protonmail so I edited in the ability to read multiple email_conf files and check them all together. Not opening a pull request yet since (1) to be able to nicely read all the email_conf files in the directory I had to add a function to mycroft.filesystem and I don't know if that's ok (I just started with Mycroft a few days ago), and (2) ideally it'd also be nice to ask Mycroft to check the inboxes separately. To get around (1) you could just import os instead of working with FileSystemAccess but that seems clunky; and I'll look into (2) when I have the time.

An error getting credentials from a config file was reported here: https://community.mycroft.ai/t/testing-of-email-skill/4353/10

Add an option to retrive the password from a command line password manager like pass. This would really improve security as the password would no longer be stored anywhere in plain text.

Knowing if you have a new email is nice, however this would be much more useful if Mycroft could actually read certain messages to you and ask if you'd like to mark them as read.

Hey, this skill actually has releases! 😄

I'm wondering if you could make a new release, since it seems e77b6fc is quite important to get it running with the latest Mycroft.

Hey Linus, just had a translator flag this dialog string.
https://github.com/LinusS1/email-skill/blob/master/locale/en-us/update.notify.data.dialog

Not at all a major thing, but thought you'd want to know :)

Using Config file with self.config in skills will end with the 19.08 release. Change so that it uses another file if users don't want to use home. The file will be ~/.mycroft/email-skill/email.yml. I will use yaml.

Before 19.08:

• Define self.config in the skill.

In the Longer Run:

• Change code to use YAML file, over home settings, if existent.

• Keep backwards compatibility with Config file

I might want to have the skill say if the user is using the old config file something like: You are using the old version of configuring the skill on the device. Please go to [insert url here] to learn more.

• Update docs

  • Change the config file to the yaml file
  • Create a "moving" page which user will land on when directed by the skill (see above)

• Promote change.

First of all, congratulations for this skill!

I was thinking it will be super useful to tell mycroft to notice me when I waiting for an concrete email from someone. I do not want -personally- to get noticed of each and every email I get, but if I'm waiting for someone's answer or perhaps some monitor alert of my job, tell Mycroft something like "let me know when I get an email from {sender}".

What do you think?