Coder Social home page Coder Social logo

Comments (3)

linkesch avatar linkesch commented on August 11, 2024

What div would you like to replace by figure? The one that wraps an inserted image? It seems like a good idea. To be honest, the only reason I used "traditional" div is that I'm not completely used to all those new HTML5 elements.

If you would like, you can make a new pull request with this enhancement.

from medium-editor-insert-plugin.

abitdodgy avatar abitdodgy commented on August 11, 2024

It would be far more semantic to use figure, yes. It would also allow for caption and other possibilities. This might be something I am able to do. I'll give it a stab when I start working on my project again.

I'm thinking of wrapping the image in a figure tag instead of the div, but I'm not sure if that breaks things.

$progress.before('
  <figure class="mediumInsert-images">
    <img src="'+ jqxhr.responseText +'" draggable="true" alt="">
  </figure>');
$img = $progress.siblings('img');
// ...

from medium-editor-insert-plugin.

linkesch avatar linkesch commented on August 11, 2024

Yes, that should be enough. To make sure, nothing broke, run tests: grunt test

from medium-editor-insert-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.