Coder Social home page Coder Social logo

Comments (3)

linkesch avatar linkesch commented on August 11, 2024

Good point, but I see that your server returns absolute path to an uploaded image and your RegExp handles only that. To make a really universal solution, we need to think about relative paths, too.

You wrote, that your upload script returns nothing, if an image wasn't uploaded. Maybe better would be just to test, if jqxhr.responseText is empty or not. What do you think?

You can make it yourself and submit a pull request, or I will make it in the future.

from medium-editor-insert-plugin.

angheloko avatar angheloko commented on August 11, 2024

Testing for blank return value is also OK. I'm just thinking if there'd be a case where the developer might want to display the error / reason. Displaying the error / reason might be "intrusive" and may not be the ideal behavior for an editor that aims to be minimalist but what would be the best way to let the user know of the error.

I can do a pull request.

from medium-editor-insert-plugin.

linkesch avatar linkesch commented on August 11, 2024

Maybe a good way to do it would be to replace a progress bar with an error message and to hide it after 5 seconds or so.

from medium-editor-insert-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.