gruvbox_italicize_strings option doesn't work about vim-gruvbox8

[lifepillar]

It does work for me. Please provide more details:

• OS?
• Vim or Neovim?
• Vim version
• GUI or terminal? Specify terminal.
• Inside tmux/screen?
• echo &t_Co
• echo &t_ZH

[lifepillar]

Also, please test with this minimal vimrc (save somewhere as vimrc_minimal):

set nocompatible
filetype on
filetype plugin on
filetype indent on
syntax on
set backupdir=~/.vim/tmp/backup
set directory=~/.vim/tmp/swap
if !has('nvim')
  set viminfo+=n~/.vim/viminfo
endif

let g:gruvbox_italicize_strings = 0
set background=light
colorscheme gruvbox8

Run vim -i NONE -N -u vimrc_minimal. Replace vim with nvim if you are using the latter.

[ljden]

Also just ran into this - probably an issue from somewhere else as the minimal config file works as expected

Setup:

• Ubuntu 22.04
• neovim 0.9.0
• gnome-terminal and bash
• echo &t_Co && echo &t_ZH commands not found

[ljden]

bit more digging, looks like the issue is that neovim in terminal does not ignore the value of gui=italic and gruvbox8 is only disabling italics with cterm=NONE

:verbose highlight String
String         xxx ctermfg=142 gui=italic guifg=#b8bb26
        Last set from ~/.local/share/nvim/site/pack/packer/start/vim-gruvbox8/colors/gruvbox8.vim line 1254

https://github.com/lifepillar/vim-gruvbox8/blob/master/colors/gruvbox8.vim#LL1252-L1255
Commenting out line 1254, String is set on line 809
https://github.com/lifepillar/vim-gruvbox8/blob/master/colors/gruvbox8.vim#LL809
Commenting out line 809, String is set on line 175
https://github.com/lifepillar/vim-gruvbox8/blob/master/colors/gruvbox8.vim#LL175

[ljden]

Found it! gui highlight attributes are used in neovim if termguicolours is set
A possible fix for this is changing line 196 to be

-  if has('gui_running')
+  if has('gui_running') || (has('nvim') && &tgc)

[lifepillar]

Yes, Neovim interprets termguicolors differently from Vim (where it applies to colors, not attributes).

At this point, I think that I will create a branch release for Neovim. Reconciling the differences is getting tiresome.

[lifepillar]

Please switch to the neovim branch of this repo or download a -neovim release. Feel free to reopen if there are further issues.

[ljden]

Thanks for the quick turn around!