Coder Social home page Coder Social logo

Comments (9)

lifepillar avatar lifepillar commented on August 29, 2024

Possibly related to a recently merged pull request: #42.

@casonadams I see that you have included some changes to otherwise transparent background colors for the sign column. Can you confirm that what the OP shows depends on those changes?

Perhaps, then, those commits should be reverted.

from vim-gruvbox8.

timsofteng avatar timsofteng commented on August 29, 2024

Possibly related to a recently merged pull request: #42.

@casonadams I see that you have included some changes to otherwise transparent background colors for the sign column. Can you confirm that what the OP shows depends on those changes?

Perhaps, then, those commits should be reverted.

Thanks for fast response.
I faced up with this issues long time ago. Just didn't open issue.

btw in with this plugin https://github.com/tanvirtin/vgit.nvim signs display correctrly:
image

from vim-gruvbox8.

lifepillar avatar lifepillar commented on August 29, 2024

Ok,I'll investigate further.

from vim-gruvbox8.

lifepillar avatar lifepillar commented on August 29, 2024

I don't see anything wrong in Gruvbox 8 re this issue. In particular, the background color of the sign column is never set to yellow or green, so it's not the color scheme that sets those colors. You should check whether the plugins you are mentioning are setting those colors.

Also please take a look at unused part of that column. Should this color be different from background?

Yes, that is by design, and I think it's just like the original Gruvbox. You may define:

hi SignColumn ctermbg=NONE guibg=NONE

in your vimrc after loading the color scheme if you want to remove the background.

from vim-gruvbox8.

timsofteng avatar timsofteng commented on August 29, 2024

Got it! How about reverse colours on the first screen? May it be fixed? I mean inversion

from vim-gruvbox8.

lifepillar avatar lifepillar commented on August 29, 2024

Got it! How about reverse colours on the first screen? May it be fixed? I mean inversion

As I said, I think those are set by some plugin. You may use the :sign command to list the defined signs. That might give you a hint about who is defining them. For instance:

:sign place buffer=N

where N is the number of the buffer with the sign column.

from vim-gruvbox8.

timsofteng avatar timsofteng commented on August 29, 2024

Got it! How about reverse colours on the first screen? May it be fixed? I mean inversion

As I said, I think those are set by some plugin. You may use the :sign command to list the defined signs. That might give you a hint about who is defining them. For instance:

:sign place buffer=N

where N is the number of the buffer with the sign column.

Hm. I've tried to figure out but I got just this:
image

I've just noticed that inverstions is only with your gruvbox.
I've tried another gruvbox colorschemes and they are ok.
But I like your colorsceme and don't want to change it due to this small reason.

from vim-gruvbox8.

lifepillar avatar lifepillar commented on August 29, 2024

Have you specified the right buffer number? Does that buffer have visible signs?

I have tried with Signify, and with a buffer that looks like this:

signs

I get this:

:sign place buffer=5

--- Signs ---                                                                                                                        
Signs for /Users/me/.vim/vimrc:
    line=805  id=256  name=SignifyChange  priority=10
    line=806  id=257  name=SignifyAdd  priority=10

With :sign list I can get the highlight groups associated to those signs:

:sign list

sign SignifyAdd text=+  linehl= texthl=SignifySignAdd
sign SignifyChange text=!  linehl= texthl=SignifySignChange                                                                          
sign SignifyChangeDelete text=!‾ linehl= texthl=SignifySignChangeDelete
sign SignifyRemoveFirstLine text=‾  linehl= texthl=SignifySignDeleteFirstLine

Then, I can see how those highlight groups are defined:

:hi SignifySignAdd
SignifySignAdd xxx links to DiffAdd

:hi SignifySignChange
SignifySignChange xxx links to DiffChange

So, you see “inverted” colors because those highlight groups link to DiffAdd and DiffChange, which in this color scheme are defined as follows (in the terminal):

:hi DiffAdd
DiffAdd        xxx term=bold cterm=reverse ctermfg=142 ctermbg=235 […]

:hi DiffChange
DiffChange     xxx term=bold cterm=reverse ctermfg=107 ctermbg=235 […]

You don't see “inverted” colors with other color schemes likely because they do not define cterm=reverse and/or they do not define a background color for those highlight groups (or they do not define those highlight groups at all).

I am not going to change DiffAdd and DiffChange in gruvbox8. But you may read about a possible resolution in a similar issue for Solarized 8: lifepillar/vim-solarized8#55.

from vim-gruvbox8.

lifepillar avatar lifepillar commented on August 29, 2024

Closing as Gruvbox 8 sets colors as intended. To override some highlight groups, this guide may be useful: How to override a colorscheme?.

from vim-gruvbox8.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.