lidyl / phicore Goto Github PK

I saw an issue when trying to read data, that it was not possible with some data (both raw data and after being processed).

It was solved once adding "backend='pytables' " to the read_xarray function call. This makes sense after some investigation, since the default backend for write_xarray is pytables, but is h5py for read_xarray. Antoine seems to remember that there is a reason for this, but it also seems to effect the data somehow. Data that was written with h5py is viewable in hdfViewer, but the data written with pytables is not.

Is there a fundamental issue here that we shoudl change?

Currently, when one opens a file that is not HDF5 with phicore.io.PhiDataFile, the error is raised in read_xarray and other methods.

It would be helpful to add a validate=True parameter to __init__, which if true will check immediately that in read or append mode, at least self.open('r') works (meaning that the file is a valid HDF5 file).