The lxltools from libris

lxltools's People

Contributors

Stargazers

Watchers

lxltools's Issues

Adapt REST API to TPF

It seems beneficial to adapt the REST API to the Triple Pattern Fragment Spec.

Building dataset definitions fails due to PosixPath AttributeError

Me and @jannistsiroyannis was trying to get LibrisXL up and running in my environment, but it fails when using current lxltools (0.6.0 tag).

How to reproduce (CentOS 7):

git clone https://github.com/libris/definitions
cd definitions
virtualenv venv && . venv/bin/activate
pip install -r requirements.txt
python dataset.py

When execution reach "languages" dataset, the following error occur:

/.../
Writing: build/relator/writerOfAddedLyrics.jsonld
Writing: build/relator/writerOfAddedText.jsonld

Dataset: languages
Traceback (most recent call last):
  File "datasets.py", line 296, in <module>
    compiler.main()
  File "/vagrant/devops/repositories/definitions/venv/src/lxltools/lxltools/datacompiler.py", line 58, in main
    self._run(args.datasets)
  File "/vagrant/devops/repositories/definitions/venv/src/lxltools/lxltools/datacompiler.py", line 74, in _run
    self._compile_datasets(names)
  File "/vagrant/devops/repositories/definitions/venv/src/lxltools/lxltools/datacompiler.py", line 99, in _compile_datasets
    result = build()
  File "datasets.py", line 207, in languages
    'iso6391.ttl').query(cherry_pick_loc_lang_data)
  File "datasets.py", line 37, in _get_zipped_graph
    with zipfile.ZipFile(path, 'r') as zipped:
  File "/usr/lib64/python2.7/zipfile.py", line 766, in __init__
    self._RealGetContents()
  File "/usr/lib64/python2.7/zipfile.py", line 803, in _RealGetContents
    endrec = _EndRecData(fp)
  File "/usr/lib64/python2.7/zipfile.py", line 208, in _EndRecData
    fpin.seek(0, 2)
AttributeError: 'PosixPath' object has no attribute 'seek'
(venv)[vagrant@default definitions]$ exit

Recommend Projects