windows buildbot build failure. about ppsspp

[Marcelo20XX]

What parameters do you use on the shell? I am getting the following error while trying to compile with msys32 and windows7:

$ ./libretro-build.sh ppsspp
PLATFORM: win
ARCHITECTURE: x86_64
TARGET: win
CC = mingw32-gcc
CXX = mingw32-g++
CXX11 = mingw32-g++
STRIP =
Compiler: CC="mingw32-gcc" CXX="mingw32-g++"
=== x86 CPU detected... ===
=== x86_64 CPU detected... ===
win
win
=== PPSSPP
Building ppsspp...
cd "/e/Emu/Sources/Libretro/libretro-super/libretro-ppsspp/libretro"
make platform="win-opengl" -j2  clean
g++ -DGIT_VERSION=\"" dd73f91"\" -fpermissive -D_UNICODE -DUNICODE  -std=c++11 -O2 -DNDEBUG  -D__LIBRETRO__ -DINLINE="inline" -DPPSSPP -DUSE_FFMPEG -DBAKE_IN_GIT -DPROFILE_THIS_SCOPE\(x\) -DGLEW_STATIC -DGLEW_NO_GLU -DNO_VULKAN  -I. -I.. -I../Common -I../libretro -I../ext/native -I../ext/zlib -I../ext/snappy -I../ffmpeg  -I../ext/cityhash -I../ext/armips -I../ext/native/ext/libzip -I../ext/native/ext -I../ext/native -I../ext/libkirk -I../ext/xbrz -I../ext/xxhash -I../ext/native/ext/rg_etc1 -I../ext/glew      -msse -msse2 -D_M_X64 -D_ARCH_64 -DHAVE_OPENGL  -DDYNAREC  -c -o../GPU/GLES/FramebufferManagerGLES.o ../GPU/GLES/FramebufferManagerGLES.cpp
In file included from ../GPU/GLES/FramebufferManagerGLES.cpp:21:0:
../ext/native/profiler/profiler.h:43:0: warning: "PROFILE_THIS_SCOPE" redefined
 #define PROFILE_THIS_SCOPE(cat)

<command-line>:0:0: note: this is the location of the previous definition
../GPU/GLES/FramebufferManagerGLES.cpp: In member function 'virtual void FramebufferManagerGLES::UpdateDownloadTempBuffer(VirtualFramebuffer*)':
../GPU/GLES/FramebufferManagerGLES.cpp:592:15: error: 'G3D' was not declared in this scope
  _assert_msg_(G3D, nvfb->fbo, "Expecting a valid nvfb in UpdateDownloadTempBuffer");
               ^~~
../GPU/GLES/FramebufferManagerGLES.cpp:592:15: note: suggested alternative:
In file included from ../Common/Common.h:38:0,
                 from ../Core/MemMap.h:28,
                 from ../GPU/GLES/FramebufferManagerGLES.cpp:32:
../Common/Log.h:46:2: note:   'G3D'
  G3D,
  ^~~
../GPU/GLES/FramebufferManagerGLES.cpp:592:2: error: '_assert_msg_' was not declared in this scope
  _assert_msg_(G3D, nvfb->fbo, "Expecting a valid nvfb in UpdateDownloadTempBuffer");
  ^~~~~~~~~~~~
../GPU/GLES/FramebufferManagerGLES.cpp:592:2: note: suggested alternative: '_dbg_assert_msg_'
  _assert_msg_(G3D, nvfb->fbo, "Expecting a valid nvfb in UpdateDownloadTempBuffer");
  ^~~~~~~~~~~~
  _dbg_assert_msg_
make: *** [Makefile:444: ../GPU/GLES/FramebufferManagerGLES.o] Error 1
make platform="win-opengl" -j2 CC="mingw32-gcc" CXX="mingw32-g++"
g++ -DGIT_VERSION=\"" dd73f91"\" -fpermissive -D_UNICODE -DUNICODE  -std=c++11 -O2 -DNDEBUG  -D__LIBRETRO__ -DINLINE="inline" -DPPSSPP -DUSE_FFMPEG -DBAKE_IN_GIT -DPROFILE_THIS_SCOPE\(x\) -DGLEW_STATIC -DGLEW_NO_GLU -DNO_VULKAN  -I. -I.. -I../Common -I../libretro -I../ext/native -I../ext/zlib -I../ext/snappy -I../ffmpeg  -I../ext/cityhash -I../ext/armips -I../ext/native/ext/libzip -I../ext/native/ext -I../ext/native -I../ext/libkirk -I../ext/xbrz -I../ext/xxhash -I../ext/native/ext/rg_etc1 -I../ext/glew      -msse -msse2 -D_M_X64 -D_ARCH_64 -DHAVE_OPENGL  -DDYNAREC  -c -o../GPU/GLES/FramebufferManagerGLES.o ../GPU/GLES/FramebufferManagerGLES.cpp
In file included from ../GPU/GLES/FramebufferManagerGLES.cpp:21:0:
../ext/native/profiler/profiler.h:43:0: warning: "PROFILE_THIS_SCOPE" redefined
 #define PROFILE_THIS_SCOPE(cat)

<command-line>:0:0: note: this is the location of the previous definition
../GPU/GLES/FramebufferManagerGLES.cpp: In member function 'virtual void FramebufferManagerGLES::UpdateDownloadTempBuffer(VirtualFramebuffer*)':
../GPU/GLES/FramebufferManagerGLES.cpp:592:15: error: 'G3D' was not declared in this scope
  _assert_msg_(G3D, nvfb->fbo, "Expecting a valid nvfb in UpdateDownloadTempBuffer");
               ^~~
../GPU/GLES/FramebufferManagerGLES.cpp:592:15: note: suggested alternative:
In file included from ../Common/Common.h:38:0,
                 from ../Core/MemMap.h:28,
                 from ../GPU/GLES/FramebufferManagerGLES.cpp:32:
../Common/Log.h:46:2: note:   'G3D'
  G3D,
  ^~~
../GPU/GLES/FramebufferManagerGLES.cpp:592:2: error: '_assert_msg_' was not declared in this scope
  _assert_msg_(G3D, nvfb->fbo, "Expecting a valid nvfb in UpdateDownloadTempBuffer");
  ^~~~~~~~~~~~
../GPU/GLES/FramebufferManagerGLES.cpp:592:2: note: suggested alternative: '_dbg_assert_msg_'
  _assert_msg_(G3D, nvfb->fbo, "Expecting a valid nvfb in UpdateDownloadTempBuffer");
  ^~~~~~~~~~~~
  _dbg_assert_msg_
make: *** [Makefile:444: ../GPU/GLES/FramebufferManagerGLES.o] Error 1
cp "ppsspp_libretro.dll" "/e/Emu/Sources/Libretro/libretro-super/dist/win_x86/ppsspp_libretro.dll"
cp: cannot stat 'ppsspp_libretro.dll': No such file or directory
1 core(s) failed:
   ppsspp

[orbea]

@Marcelo20XX Thanks for taking an interest in this!

The recipes uses for ppsspp on windows can be found here.
https://github.com/libretro/libretro-super/blob/master/recipes/windows/cores-windows-x64_seh-generic
https://github.com/libretro/libretro-super/blob/master/recipes/windows/cores-windows-x86_dw2-generic

In short the recipes are:

ppsspp libretro-ppsspp https://github.com/libretro/ppsspp.git master YES GENERIC_GL Makefile libretro platform=windows_msvc2017_desktop_x64

and

ppsspp libretro-ppsspp https://github.com/libretro/ppsspp.git master YES GENERIC_GL Makefile libretro platform=windows_msvc2017_desktop_x86

So they are using libretro/Makefile and passes the arguments platform=windows_msvc2017_desktop_x64 or platform=windows_msvc2017_desktop_x86 to make.

Alternatively the recipes might be able to be changed to cmake in this specific case since upstream prefers that. For linux only -DLIBRETRO=ON needs to be passed to cmake, but as I have no windows install I can't really play with this. :)

[Marcelo20XX]

Ok, just so I get this straight, do I need to install Microsoft Visual Studio 2017? maybe because that is what I am missing I get this bunch of errors... If so I would see if I can install the community edition but it will slow me down...

For compiling I tried the following with no results: after fetching the ppsspp core I invoked a github shell on the libretro-super and typed the following command "$ ./libretro-build.sh ppsspp" that game me the error I posted...

Next I tried from the libretro-super/libretro-ppsspp/libretro the command "make.exe -f Makefile platform=win -j6 platform=windows_msvc2017_desktop_x86 clean" also without success and the same error as posted before...

What else should I try? thanks!

[orbea]

To be honest I'm not sure what tool chain is required, last time I used windows it was vista and I had no idea what I was doing... I'll try to see if anyone more familiar with windows can help out.

I'm also not very familiar with libretro-build.sh, when I test the recipes I use libretro-buildbot-recipe.sh which is the script used by the buildbot.

It can be used like this.

SINGLE_CORE=ppsspp FORCE=YES ./libretro-buildbot-recipe.sh recipes/windows/cores-windows-x64_seh-generic

You do not necessarily need FORCE=YES unless the source has already been cloned and there are no new commits. If SINGLE_CORE is not used it will build every core in the recipe file specified.

[orbea]

I asked in #retroarch.

17:13:22 @bparker orbea: just regular mingw on msys2
17:13:31 @bparker same used for compiling RA itself
17:13:52 orbea thanks, I'll pass that along
17:14:38 @bparker oh, ppsspp uses msvc2017
17:14:43 @bparker so you'll need that too
17:15:09 @bparker you can install only the build tools version if you don't need the full IDE

[Marcelo20XX]

I see, so I am missing the build tools version from msvc2017 that's why I am having a different error than you, I will see what I can do and report back, thanks!

[orbea]

I'm told it builds with windows now so I will close this.