Coder Social home page Coder Social logo

Update to 2.1.99 about mdi-react HOT 5 CLOSED

levrik avatar levrik commented on July 27, 2024
Update to 2.1.99

from mdi-react.

Comments (5)

levrik avatar levrik commented on July 27, 2024 2

Released in 3.0.0

from mdi-react.

felixfbecker avatar felixfbecker commented on July 27, 2024 1

I think it doesn't matter if I include it via a submodule or npm.

Here are the benefits I see:

  • npm info react-mdi@$VERSION devDependencies.mdi easily gives me the version of mdi a certain version of react-mdi was built from (which is more important now that the versioning is decoupled).
  • A green devDependencies up-to-date badge can highlight in the readme that it is built from the latest mdi
  • Greenkeeper/Renovate/... can do automatic PRs to update
  • CI can use the npm cache

from mdi-react.

levrik avatar levrik commented on July 27, 2024

Since I'm not shipping the original SVG files with this library (transforming them into SVG components instead) I won't include mdi-svg as an dependency. At the moment I'm trying to come up with some new versioning since the current one doesn't work well. See #9 for more information. I'm open for feedback about that, especially since you're the creator of mdi.

from mdi-react.

Templarian avatar Templarian commented on July 27, 2024

Yea, that works. As long as there is an easy way for people to know what version of mdi is included the version can be anything. 😃

Sorry for the confusion I meant as a NPM dev dependency instead of the git submodule (didn't look at the scripts, but assuming it's extracting data from them).

from mdi-react.

levrik avatar levrik commented on July 27, 2024

@Templarian Ah, got it. I think it doesn't matter if I include it via a submodule or npm. The published module is different from the one which needs to pull in mdi. (package.json on the top-level is never published, only the one in the publish folder.)

from mdi-react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.