Comments (5)
Released in 3.0.0
from mdi-react.
I think it doesn't matter if I include it via a submodule or npm.
Here are the benefits I see:
npm info react-mdi@$VERSION devDependencies.mdi
easily gives me the version ofmdi
a certain version ofreact-mdi
was built from (which is more important now that the versioning is decoupled).- A green devDependencies up-to-date badge can highlight in the readme that it is built from the latest mdi
- Greenkeeper/Renovate/... can do automatic PRs to update
- CI can use the npm cache
from mdi-react.
Since I'm not shipping the original SVG files with this library (transforming them into SVG components instead) I won't include mdi-svg
as an dependency. At the moment I'm trying to come up with some new versioning since the current one doesn't work well. See #9 for more information. I'm open for feedback about that, especially since you're the creator of mdi
.
from mdi-react.
Yea, that works. As long as there is an easy way for people to know what version of mdi is included the version can be anything.
Sorry for the confusion I meant as a NPM dev dependency instead of the git submodule (didn't look at the scripts, but assuming it's extracting data from them).
from mdi-react.
@Templarian Ah, got it. I think it doesn't matter if I include it via a submodule or npm. The published module is different from the one which needs to pull in mdi
. (package.json
on the top-level is never published, only the one in the publish
folder.)
from mdi-react.
Related Issues (20)
- Support TypeScript `module: node16`/`nodenext`
- Support tooltip display by passing a title child element
- Re-export all modules from an index.js file HOT 2
- Element type is invalid: expected a string (for built-in components) or a class/function but got: object HOT 3
- Is the 360 icon missing a corresponding component HOT 2
- Element type is invalid: expected a string HOT 3
- Module parse failed: Unexpected keyword 'var' HOT 4
- Update to mdi/svg 4.3.95 HOT 6
- Changelog is not friendly for developers deciding whether to upgrade HOT 1
- mdi-react-native HOT 6
- mdi-text-box icons are missing HOT 8
- Please specify entry point in package.json HOT 1
- Update to latest MDI HOT 4
- Prevent automatic icon resize
- Generate an index.js HOT 1
- HelpOutlineIcon looks exact like HandshakeOutlineIcon HOT 1
- Some icons not available HOT 4
- Dependency Dashboard
- package.json exports field support
- How to set title attribute on an icon? HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mdi-react.