lesona-systems / underwolf Goto Github PK

Currently Underwolf starts a new driver (or is written to, I'm digging into Selenium) for each download call. That's not performant. We should be able to use a single visible instance (for downloading addons) and a single headless instance (for version checking) for both parts of the flow - version checking and downloading.

This is poor original code on my part, so we're going to clean it up! Help is welcome 💯

The script is failing to cleanup the Addons folder created in Downloads on all platforms. Should switch to Python's tempfile/tempdir.

Right now, we're explicitly creating a directory in the user's download folder to hold unpacked addons and then manually removing that directory with shutil.rmtree({dir}). While this doesn't necessarily create issues (besides the nuclear qualities of shutil), it does add several points of friction in both code size and execution time. Additionally, it doesn't seem particularly Pythonic.

Suggest utilizing the tempfile Python lib to create a temporary directory for unpacking addons into, and then copying into the /Addons folder in the World of Warcraft directory.

I'd love for a '--forceupdate' arg to bypass ALL version checking. This is helpful when doing a fresh install or directly after a big World of Warcraft patch. Currently this can be achieved by zeroing out last_updated in the addon master, but a simple flag would be best.

Right now I'm leaning towards a --forceupdate that will still write 'last_updated' key/values despite downloading the addons without checking that field at all. Love to hear some thoughts RE this.

Eventually legacy.curseforge.com is going to be deprecated, and the new site only has standard dates (just the day/month) available. --forceupdate would be huge here, due to the fact that addon maintainers will upload several builds on the same patch day.

Curseforge has completed a website overhaul, meaning that users can use either legacy.curseforge.com as well as curseforge.com to download their addons. Anything named "legacy" is likely not long for this world, so Underwolf should be capable of ingesting either a legacy URL or a current Curseforge URL and properly do version checking.

There is a slight downside to using Cuseforge.com over legacy.curseforge.com, which is that CF no longer records the exact update time (in epoch) in its front end. That's what we still use for version checking on the legacy site. Instead, CF provides a month, day, and year on its front end, structured as

Month Day, Year

for example:

Jan 29, 2023

This sucks, frankly, but we'll have to work around it. With the recent "--forceupdate" commit, it's more feasible to support both the legacy site as well as the current one.

Tukui has removed both TukUI and ElvUI versions from the splash page, so we're going to have to change the XPath and anchor links for any Tuk/Elv for version checking to complete successfully.

After TukUI's removal of version information on its homepage, TukUI has also changed the download logic for both of its addons. They now require a click on the download button that sends an API call to serve the correct download.

We should implement Selenium's click() function on the download button element.