Comments (6)
Just curious, wouldnt it be better to have both? Personally I always use nightly because I like not having the .get()
or .set()
syntax (and I can use stuff like the parallel frontend in the compiler) but I understand why its a good idea to show that it works fine in stable, so why not keep both?
But yeah, I think I can take care of the hackernews examples and maybe some of the counter ones
from leptos.
Personally I always use nightly because I like not having the
.get()
or.set()
syntax (and I can use stuff like the parallel frontend in the compiler)
Me too, which is why it's been the default until now.
but I understand why its a good idea to show that it works fine in stable, so why not keep both?
My main concern is actually CI-related. We have not had many problems until fairly recently, but the instability of nightly APIs means that occasionally, things break and need to be fixed in CI in ways that can be confusing for people trying to use the examples.
One small case study that prompted me to open this: A few months ago, we found that rkyv
was throwing clippy warnings on new nightly versions, which was breaking our CI during cargo check
on leptos_reactive
featurs that pulled in rkyv
. I probably should've investigated more deeply at the time (it turns out just disabling the copy
feature on rkyv
would've fixed it) but we just pinned to a nightly version that worked, instead.
Then some time in the last few weeks, an Axum patch update was released that was only compatible with more recent nightly compilers — but rkyv
still wasn't. This meant we were in an uncanny valley where there was no nightly version of the compiler that could actually cause our CI to pass. I ended up spending a few hours of my day yesterday just dealing with the consequences of that combination and updating to a new nightly.
Ultimately this stuff is just a pain, and it will continue to be a pain as long as we have nightly examples that we're running CI against — hence why I'd rather replace them than just add more stable examples.
But yeah, I think I can take care of the hackernews examples and maybe some of the counter ones
Thanks!
from leptos.
Okay, I'll work on error_boundary.
from leptos.
My main concern is actually CI-related. We have not had many problems until fairly recently, but the instability of nightly APIs means that occasionally, things break and need to be fixed in CI in ways that can be confusing for people trying to use the examples.
One small case study that prompted me to open this: A few months ago, we found that
rkyv
was throwing clippy warnings on new nightly versions, which was breaking our CI duringcargo check
onleptos_reactive
featurs that pulled inrkyv
. I probably should've investigated more deeply at the time (it turns out just disabling thecopy
feature onrkyv
would've fixed it) but we just pinned to a nightly version that worked, instead.Then some time in the last few weeks, an Axum patch update was released that was only compatible with more recent nightly compilers — but
rkyv
still wasn't. This meant we were in an uncanny valley where there was no nightly version of the compiler that could actually cause our CI to pass. I ended up spending a few hours of my day yesterday just dealing with the consequences of that combination and updating to a new nightly.Ultimately this stuff is just a pain, and it will continue to be a pain as long as we have nightly examples that we're running CI against — hence why I'd rather replace them than just add more stable examples.
Yeah, CI breaking because small issues at random due to breaks in nightly can become a huge pain when piled on, I get why you would want to move it and after converting a few examples, aside from having to move errors into closures tbh it wasnt that different
from leptos.
I'll work on counter_url_query
from leptos.
Thanks to everyone for contributing! I think this is all of them. Much appreciated ❤️
from leptos.
Related Issues (20)
- Nested Suspense ignores SSR Mode and breaks Hydration HOT 2
- Error when running server function inside spawn_local HOT 5
- Click events are registered twice when two leptos custom elements are on a page HOT 4
- about mobile support
- Recursive effects never run after recursing HOT 5
- Clippy warnings in some components with rust 1.78 HOT 1
- rkyv, avoid the copy to byte ? HOT 4
- Check ActionForm input names at compile time HOT 4
- Allow server components in islands architecture to call code behind ssr without need for #[server] HOT 1
- porting over some react code to my project, having hydration issues
- leptos_router parent Route attr view is not generating view for dynamic routes HOT 4
- relese build causes SIGSEGV and SIGBUS while dev build is just fine HOT 3
- `HtmlElement::attrs` and `DynAttrs::dyn_attrs` Accept `&'static str` Instead of `Oco<'static, str>` HOT 2
- Notify crate (lib) not compiling when installing cargo-leptos HOT 1
- Query parameters are not properly escaped
- DeserializationError when using create_resource of data that use #[serde(deserialize_with = "xxx")] HOT 3
- Boolean aria attribute values are not handled correctly HOT 3
- LocatorJS integration HOT 1
- Enabling the rkyv feature is failing to compile
- Error during hydration of a recursive component HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from leptos.