leosoaivan / top_ror_odinfb

A simplified Rails clone of the popular social network

Odin Facebook

Odin Facebook is the final project of The Odin Project's Rails curriculum. The assignment can be found here. The project is live via Heroku here

The primary challenge was configuring the user associations, given that, in a symmetrical, Facebook-style relationship, a user can be either a user requesting a friendship or a user receiving a friendship request.

This project was also the first opportunity I had to play around with Devise, which is a beast in and of itself.

Getting Started

N/A

Prerequisites

N/A

Installing

N/A

Running the tests

1. Make sure you have RSpec installed

   gem install rspec

2. Run the tests!

   $ rspec

Deployment

N/A

Built With

• Ruby on Rails - Web framework
• Bootstrap - HTML/CSS framework
• PostgreSQL - Database
• Rspec/Capybara - Test suite
• Heroku - Cloud platform/server
• SendGrid - Email delivery service

To-Do

1. Add testing for Mailer

Contributing

1. Fork it!
2. Create your feature branch: git checkout -b my-new-feature
3. Commit your changes: git commit -am 'Add some feature'
4. Push to the branch: git push origin my-new-feature
5. Submit a pull request :D

Versioning

• Ruby 2.4.1
• Rails 5.0.2

Authors

• LPSV

License

N/A

Acknowledgments

• The Odin Project
• Google
• Stack Overflow
• RailsCasts #163: Self-Referential Association

top_ror_odinfb's Issues

Deleting other users' friends!!!

As described above. This would be quite the social network.

confirmation error

when i click on confirmation link it says

Limit number of visible comments on posts that are not posts#show pages (feed, profile, etc...)

When a user visits their feed, their profile, or another user's profile, they can look at posts and load the comments for any individual or multiple posts. In doing so, they should see a limited number (5? 10?) of the most recent comments. They should also have the option to load more/all the comments on a post with the click of button/link.

Non-confirmed friends appear in feed

Subject of the issue

Non-confirmed users (users that have sent primary user a friend request) appear on primary user's feed.

Steps to reproduce

1. Log in to user 1 and send a request to user 2
2. Log out of user 1
3. Log in to user 2 and navigate to user 2's profile

Expected behaviour

User 1 should not show up on user 2's feed in the profile without being confirmed.

Actual behaviour

User 1 appears on user 2's feed in the profile without being confirmed.

Incorrect flash messages following FriendshipsController actions

Subject of the issue

Incorrect/inaccurate flash messages when sending a friend request and deleting friend requests. The corresponding flash messages are worded as though a user is adding or deleting actual friends.

Steps to reproduce

After navigating to users/index:

1. Click on button 'Request Friend' to see the corresponding flash.
2. Click on button 'Delete Request' to see the corresponding flash.

Expected behaviour

1. The flash should say something like 'Friend request has been successfully sent.'
2. The flash should say something like 'Friend request successfully deleted.'

Actual behaviour

1. The flash reads 'Added friend.'
2. The flash reads 'You've unfriended someone.'

Infinite scrolling for posts (and comments?)

When signed in, a user should be able to scroll infinitely through portions (10 posts? 15 posts?) of all posts, including those in a user's feed, on a user's profile, and on other users' profiles. Currently, they load all at once when called via User.feed.

For comments, infinite scrolling would make it too difficult to scroll through posts while on the feed, as the comments expand from each individual post. Infinite scrolling for comments would have to be implemented on individual post#show pages.

Pagination for users index

Double friending

Currently, when two users friend each other and both accept the request, it results in two active friendships between the users. This is because a friendship consists of user (request sender) and friend (request receiver) IDs.

In this particular scenario, the resulting friendships might look like this:

Friendship(id: 1, user_id: 1, friend_id: 2)
Friendship(id: 2, user_id: 2, friend_id: 1)

The two resulting friendships, while both referring to the same users, are still considered valid and unique.