lenis0012 / npcfactory Goto Github PK

If an NPC is right clicked, using this event will not do anything, instead you have to get the entity by the PlayerInteractEntityEvent and checking the entity that is right-clicked has the 'NPC' metadata.

When an NPC is spawned its CraftPlayer is given the "NPC" Metadata. When a real CraftPlayer instance (actual player) is checked for the 'NPC' metadata, and an NPC has the name of the player, then it returns true. This is due to the way Player metadata is stored, it's stored 'name:key', this is a rather big issue and can easily be prevented.

1. Override the NPCEntity's CraftPlayer PlayerMetadataStore to store by entity id or something.

2. when checking for isNPC, return entity instanceof NPCEntity

I'd recommend the former.

Hi lenis! thanks for your library to create npcs!!!

I have a problem :S im using ur NPCFactory version for spigot 1.7.9 and works great, but i have a problem. I need add invisibility potion effect to a npc, but it doesnt work...

PotionEffect potion = new PotionEffect(PotionEffectType.INVISIBILITY, Integer.MAX_VALUE, 1);

npc.getBukkitEntity().addPotionEffect(potion);

what can i do? :s:
Thanks

The custom NPC does not take damage from ignited fire or lava for example, only when attacked by another entity.

I've set the damage event to not cancel. I've also set the NPC to non invulnerable.

--

Thanks

It would be nice if there was an option to hide or show an npc for a specific spectator.

the current version is for Spigot 1.8.x and i need for 1.10.x so please update it, i really love it !

I'm having this problem and I do not know how it came to be

http://prntscr.com/gl79jf
http://prntscr.com/gl79sd