lendingblock / moonwalking Goto Github PK

Hi, I'm not familiar with your project. I did a search for https://bitcoinfees.earn.com/api/v1/fees/recommended and am alerting projects using this API to inaccurate & old data.

An up-to-date API with accurate data would be https://mempool.space/api/v1/fees/recommended or some alternative.

https://github.com/lendingblock/moonwalking/blob/d377b4171c82c519e7a06d195cae49d52404c5da/moonwalking/blocks/fee.py

Hello,

There is an open bug on PyWallet issues page: ranaroussi/pywallet#14 which is quite serious and basically states that PyWallet is generating incorrect derived keys because it is not converting the mnemonic to 128-bit seeds before running it through HMAC.

This basically means, sending bitcoins to pywallet-derived addresses may cause funds loss as they are not for the correct private key.

To fix this issue you can use my fork: https://github.com/ZenulAbidin/zpywallet which patches this issue and also includes a fix for a bug in the ripemd160 hashlib function that prevents the original pywallet from running on Python 3.10 and later.