lemurpwned / filmweb-nlp

Hi there 👋

I'm dealing some physics most of the time. Other wares too, if you have coin.

• 👾 I’m looking to collaborate on cmtj repo.
• 📫 Reach me @ [email protected]
• 👌 Life-changing documentary

filmweb-nlp's Issues

pyss3 now supports user-defined path

Hi @LemurPwned! I've just made some tiny updates on pyss3 taking into account your valuable feedback, now these lines:

filmweb-nlp/spacy-workflow/sentiment-spec/sentiment/sentiment.py

Lines 8 to 12 in 58aad17

	data_loc = '/etc/cvoldata'
	# idotic, won't load from custom loc
	pyss3.SS3.__models_folder__ = os.path.join(data_loc, 'ss3_models')
	clf = pyss3.SS3()
	clf.load_model()

can be simply replaced by:

clf = pyss3.SS3()
clf.load_model('/etc/cvoldata')

In addition, this line can be safely removed (by default pyss33 looks for a local "ss3_models" folder):

filmweb-nlp/kubeflow-workflow/sentiment/sentiment.py

Line 8 in 3ea0ca0

pyss3.SS3.__models_folder__ = os.path.join('.', 'ss3_models')

If you want you can update pyss3 (pip install --upgrade pyss3) and try the new code, it will now make your code simpler and clearer. Sorry for not having taking this into account beforehand... PySS3 is a "baby" project in its 0.3 version (really far from a "1.0 version"), I know there's plenty of things to do, that's why I really appreciate your #comments, they helped me to improve the package and by doing that you also helped others using the package :) thanks, buddy!

The negative feedback is the best type of feedback because it is a "potential" improvement, so I really appreciate it. Next time do not hesitate to open an issue on the repo, any kind of help or feedback will be really appreciated.

Greets! take care and happy hacking 👍

check for 404 or something if page not found

filmweb-nlp/movie_reviews.py

Line 21 in f6b5475

def get_movie_review(self, movie_id, page):