leidenuniversitylibrary / library-search-plugin-public Goto Github PK

Thanks for the nice devday presentation today! The plugin was indeed easy to get started with :) Just one issue I encountered when loading the package into Chrome ("Load unpacked"):

Removing the file resolved the problem. Is it used for anything?

How did you answer the Google Web Store's required Privacy permission justifications for:

ContextMenu
Tabs
Storage

And, is searching an external website considered using remote code?

I have been trying to update to manifest version 3, but it will not let me publish until I answer these questions.

Thank you!

For future maintainability we want to stop using jquery in favor of pure Javascript. Translate the scripts present in the js folder.

Chrome manifest must update to V,3 specifications: https://developer.chrome.com/docs/extensions/mv3/intro/mv3-overview/

Thanks so much for making your code available. In the past, we had adapted it to allow a select all/deselect all option with this in the popuphtml

Select / Deselect All

And this in the options.js

$('#selectAll').click(function() {
if(this.checked) {
$(':checkbox').each(function() {
this.checked = true;
});
} else {
$(':checkbox').each(function() {
this.checked = false;
});
}
});

$(document).ready(function () {
//SEARCHBOX STUFF
$('#selectAll').click(function() {
if(this.checked) {
$(':checkbox').each(function() {
this.checked = true;
});
} else {
$(':checkbox').each(function() {
this.checked = false;
});
}
});

before listing all the selection ids.

Now that you are using Bootstrap's form-check, I am not sure how to add in a functioning select all/deselect all. Any help you can provide would be really appreciated.

Katie Utschig
SWITCH Library Consortium

In options.js, pubmed is being pushed through ezproxy.
It shouldn't and it will not work! It should use Pubmed's otool instead.

The plugin still uses bootstrap version 4.*. While not a problem, we should allocate some resources to pushing the plugin to and updated version.

When opening the plugin's popup.html, the console outputs an error mentioning duplicate IDs. This is because options.js repeatedly calls the "context menu" options, every time the popup is opened by the user.

1. Move the context menu options from options.js to a new file called background.js.
2. in manifest.json, call background.js instead of popup.html in the "background" section of the json.