ledil / django-orphaned Goto Github PK

View Code? Open in Web Editor NEW

40.0 40.0 15.0 27 KB

delete all orphaned files created by django (FileField)

License: Other

Python 100.00%

django-orphaned's People

Contributors

Stargazers

Watchers

Forkers

zlorf johnraz jhei joerick usgm leonardogentile asermax sspross bergsoft tgummerer verosk jualvarez xxbinxx danieltellez

django-orphaned's Issues

exclude specific files

Similar to the exclude path feature, the app can provide a setting for excluding files that are stored at the 'root' too.
For example, I have a .gitignore for avoid including this files into the git repository. When I run python manage.py deleteorphaned --info I get as output:

/var/someuser/private/.gitignore
/var/someuser/private/orphan_file.tar.gz

Maybe adding a new subsetting: exclude and using a similiar concept than in should_skip method:

# deleteorphaned.py:28
skip_files = ORPHANED_APPS_MEDIABASE_DIRS[app].get('exclude', ())
# deleteorphaned.py:55
    if basename not in exclude:
        all_files.append(os.path.join(root, basename))

Settings example:

ORPHANED_APPS_MEDIABASE_DIRS = { 
    'myapp': {
        'root': '/var/someuser/private/',
        'exclude': ('.gitignore') 
    }   
}

Crash when having stale content types

Sometypes a db has contenttypes for old models (i.e. models which were deleted or renamed). This apps tries to iterate overmodels going through ContentType objects and calling ct.model_class(), which returns None for stale content types.

That produces the following crash:

Traceback (most recent call last):
  File "./manage.py", line 20, in <module>
    execute_from_command_line()
  File "/home/admin/venv-dev/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 443, in execute_from_command_line
    utility.execute()
  File "/home/admin/venv-dev/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 382, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/home/admin/venv-dev/local/lib/python2.7/site-packages/django/core/management/base.py", line 196, in run_from_argv
    self.execute(*args, **options.__dict__)

  File "/home/admin/venv-dev/local/lib/python2.7/site-packages/django/core/management/base.py", line 232, in execute
    output = self.handle(*args, **options)
  File "/home/admin/venv-dev/local/lib/python2.7/site-packages/django_orphaned/management/commands/deleteorphaned.py", line 32, in handle
    for field in mc._meta.fields:
AttributeError: 'NoneType' object has no attribute '_meta'

Probably this can be fixed by adding a

if mc is None: continue

inside the

for field in mc._meta.fields:

loop

Publish release 0.4.2 at pypi

The last release published at the Python Package Index (PyPI) is django-orphaned 0.3[1], maybe it's time to create a new package and allow installing recent version using standar pip comand:

pip install django-orphaned

Thanks!

[1] https://pypi.python.org/pypi/django-orphaned/0.3

unicode filename support

all_files.append(os.path.join(root.decode('utf-8'), basename.decode('utf-8')))

Unusable if there are multiple apps that share common media root?

In my case all apps use a single media root directory and if I define them all in ORPHANED_APPS_MEDIABASE_DIRS they just mark each other's files for deletion. All files. Am I doing something wrong?

Skipped directories can be deleted because django_orphaned sees the parent as empty

Here's my structure:

media/
media/squarei/
media/squarei/defaults
media/squarei/defaults/example1.png
media/squarei/defaults/example2.png
media/squarei/user_upload.png

My config looks like this

ORPHANED_APPS_MEDIABASE_DIRS = {
    'squarei': {
        'root': MEDIA_ROOT,
        'skip': (
            os.path.join(MEDIA_ROOT, 'squarei/defaults'),
        ),
    }
}

django_orphaned looks at the media/squarei directory and decides it's empty, because no FileFields refer to it. But the skipped directory is in there, and is deleted when django_orphaned deletes media/squarei

TypeError: 'flat' is not valid when values_list is called with more than one field.

$ python manage.py deleteorphaned --info
Traceback (most recent call last):
  File "manage.py", line 8, in <module>
    execute_from_command_line(sys.argv)
  File "/home/foo/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 399, in execute_from_command_line
    utility.execute()
  File "/home/foo/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 392, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/home/foo/local/lib/python2.7/site-packages/django/core/management/base.py", line 242, in run_from_argv
    self.execute(*args, **options.__dict__)
  File "/home/foo/local/lib/python2.7/site-packages/django/core/management/base.py", line 285, in execute
    output = self.handle(*args, **options)
  File "/home/foo/local/lib/python2.7/site-packages/django_orphaned/management/commands/deleteorphaned.py", line 38, in handle
    files = mc.objects.all().values_list(*fields,flat=True)
  File "/home/foo/local/lib/python2.7/site-packages/django/db/models/query.py", line 533, in values_list
    raise TypeError("'flat' is not valid when values_list is called with more than one field.")
TypeError: 'flat' is not valid when values_list is called with more than one field.

ledil / django-orphaned Goto Github PK

django-orphaned's People

Contributors

Stargazers

Watchers

Forkers

django-orphaned's Issues

exclude specific files

Crash when having stale content types

Publish release 0.4.2 at pypi

unicode filename support

Unusable if there are multiple apps that share common media root?

Skipped directories can be deleted because django_orphaned sees the parent as empty

TypeError: 'flat' is not valid when values_list is called with more than one field.

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent