Comments (4)
Displaying 160-bit HEX strings is a suboptimal user-experience
Hex strings that can be decoded to all ASCII are supposed to be decoded to ASCII. I see a bug on line https://github.com/LedgerHQ/app-xrp/blob/master/src/xrp/amount.c#L176, that's supposed to be negated. If "XRP" is in the hex string, we should proceed to the else-case and display as hex.
Earlier versions of this firmware properly decoded all ASCII hex strings, e.g. 5553445400000000000000000000000000000000
to USDT
. The decoder for all ASCII can be seen here: https://github.com/LedgerHQ/app-xrp/blame/master/src/xrp/strings.c#L21 and it behaves as expected for other decoding of e.g. MemoData.
from app-xrp.
Original Towo Labs code to the left: https://github.com/TowoLabs/ledger-app-xrp/blob/master/src/xrp/format/amount.c#L64
from app-xrp.
Ping @TamtamHero, you probably wanna look at the above diff. since it inverted the intended behaviour.
from app-xrp.
This is still an issue in production. The expected behaviour has changed. Pinging for higher visibility @TamtamHero @fbeutin-ledger @tjoly-ledger @agrojean-ledger @btchip
from app-xrp.
Related Issues (11)
- Attempting to add support for InvoiceID, failing to parse transaction though unclear why HOT 1
- Transfer Rate "Invalid Value" HOT 1
- Invalid Signature returned from signTransaction HOT 1
- Ledger device: Missing critical parameter (0x6800) HOT 3
- Support 'OfferCreate' transaction type for packages/hw-app-xrp HOT 3
- Getting Started for development link doesn't work. HOT 1
- Ability To Sign Arbitrary Strings
- Support 'TrustSet' transaction type HOT 2
- Enforcing a non-empty SigningPubKey, breaking multisigned transactions
- Ripple Destination Tags Creation on LedgerNano or Ledger Blue HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from app-xrp.