Coder Social home page Coder Social logo

Comments (4)

RareData avatar RareData commented on July 23, 2024

Displaying 160-bit HEX strings is a suboptimal user-experience

Hex strings that can be decoded to all ASCII are supposed to be decoded to ASCII. I see a bug on line https://github.com/LedgerHQ/app-xrp/blob/master/src/xrp/amount.c#L176, that's supposed to be negated. If "XRP" is in the hex string, we should proceed to the else-case and display as hex.

Earlier versions of this firmware properly decoded all ASCII hex strings, e.g. 5553445400000000000000000000000000000000 to USDT. The decoder for all ASCII can be seen here: https://github.com/LedgerHQ/app-xrp/blame/master/src/xrp/strings.c#L21 and it behaves as expected for other decoding of e.g. MemoData.

from app-xrp.

RareData avatar RareData commented on July 23, 2024

Original Towo Labs code to the left: https://github.com/TowoLabs/ledger-app-xrp/blob/master/src/xrp/format/amount.c#L64

Screenshot 2022-03-18 at 09 54 21

from app-xrp.

RareData avatar RareData commented on July 23, 2024

Ping @TamtamHero, you probably wanna look at the above diff. since it inverted the intended behaviour.

from app-xrp.

RareData avatar RareData commented on July 23, 2024

This is still an issue in production. The expected behaviour has changed. Pinging for higher visibility @TamtamHero @fbeutin-ledger @tjoly-ledger @agrojean-ledger @btchip

from app-xrp.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.