Coder Social home page Coder Social logo

Comments (3)

patriksletmo avatar patriksletmo commented on July 3, 2024 1

The XRP app currently requires the flag tfFullyCanonicalSig to be set when signing transactions (https://xrpl.org/transaction-common-fields.html#global-flags). It appears that your Flags field does not contain it, which would explain why the transaction fails with the error you're seeing.

This flag has been deprecated since its introduction in this app, so it probably makes sense to remove the requirement. Please let me know what you think @RareData @natenichols.

You can find the relevant code here

app-xrp/src/xrp/xrp_parse.c

Lines 423 to 432 in 066af6b

// Reject transaction if tfFullyCanonicalSig is not set
if (field->id == XRP_UINT32_FLAGS) {
uint32_t value = field->data.u32;
if ((value & TF_FULLY_CANONICAL_SIG) == 0) {
err.err = 0x6800;
return err;
}
}
break;

from app-xrp.

RareData avatar RareData commented on July 3, 2024

I agree, enforcing tfFullyCanonicalSig is no longer necessary. Until there is a new firmware version @natenichols, increase your Flags value by the https://xrpl.org/transaction-common-fields.html#global-flags decimal value 2147483648. For example, if you intend to sign a transaction with Flags: 65536, use Flags: 2147549184 instead.

from app-xrp.

dangell7 avatar dangell7 commented on July 3, 2024

Thank you guys, I really appreciate the quick feedback.

This worked to solve the issue in the OP.

from app-xrp.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.