The app-harmony-one from ledgerhq

ledgerhq / app-harmony-one Goto Github PK

View Code? Open in Web Editor NEW

Ledger hardware wallet

Dockerfile 0.73% Makefile 1.76% Shell 2.14% Go 9.24% C 74.58% JavaScript 11.55%

app-harmony-one's People

Stargazers

Watchers

app-harmony-one's Issues

Bad signature on some edge case

app-harmony-one/src/harmony.c

Lines 60 to 73 in 6357e70

    
           void convert_signature_to_RSV(const unsigned char *tlv_signature, unsigned char *dst) { 
        
               int r_size = tlv_signature[3]; 
        
               int s_size = tlv_signature[3 + r_size + 2]; 
        
               int r_offset = r_size - 32; 
        
               int s_offset = s_size - 32; 
        
               const int offset_before_R = 4; 
        
               const int offset_before_S = 2; 
        
               os_memmove(dst, tlv_signature + offset_before_R + r_offset, 32); // skip first bytes and store the `R` part 
        
               os_memmove(dst + 32, tlv_signature + offset_before_R + 32 + offset_before_S + r_offset + s_offset, 
        
                          32); // skip unused bytes and store the `S` part 
        
           }

if r_size == 31, which can happen, then the signature will be invalid and transaction will be rejected by the blockchain.
A simpler implementation would be using cx_ecdsa_sign_rs_no_throw,a nd best would be changing all the crypto call to use directly helpers from https://github.com/LedgerHQ/ledger-secure-sdk/blob/master/lib_standard_app/crypto_helpers.h

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.

Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

TensorFlow

An Open Source Machine Learning Framework for Everyone

Django

The Web framework for perfectionists with deadlines.

Laravel

A PHP framework for web artisans

D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

web

Some thing interesting about web. New door for the world.

server

A server is a program made to process requests and deliver data to clients.

Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

Visualization

Some thing interesting about visualization, use data art

Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.

Microsoft

Open source projects and samples from Microsoft.

Google

Google ❤️ Open Source for everyone.

Alibaba

Alibaba Open Source for everyone

D3

Data-Driven Documents codes.

Tencent

China tencent open source team.

	void convert_signature_to_RSV(const unsigned char tlv_signature, unsigned char dst) {
	int r_size = tlv_signature[3];
	int s_size = tlv_signature[3 + r_size + 2];

	int r_offset = r_size - 32;
	int s_offset = s_size - 32;

	const int offset_before_R = 4;
	const int offset_before_S = 2;

	os_memmove(dst, tlv_signature + offset_before_R + r_offset, 32); // skip first bytes and store the `R` part
	os_memmove(dst + 32, tlv_signature + offset_before_R + 32 + offset_before_S + r_offset + s_offset,
	32); // skip unused bytes and store the `S` part
	}