learn-co-students / sinatra-secure-password-lab-v-000 Goto Github PK
View Code? Open in Web Editor NEWLicense: Other
License: Other
The starter code has an unnecessary route that is not required by the tests. Upon successful login, the test expects to be redirected to the /account route, not /success.
Also, the /account route does not check to see if the user is logged in.
get "/success" do
if logged_in?
erb :success
else
redirect "/login"
end
end
The signup page test for no password given is the same as the test for no username given.
Ok so I was looking at the tests on this lab and noticed currently I can pass without creating a user on sign up.
post "/signup" do
if params.values.any?{|v| v.empty?}
redirect '/failure'
else
redirect '/login'
end
end
The above code passes because the tests are creating the users for us.
I'd say add a test for sign up that checks if that user was created after filling the sign up form to ensure test doesn't pass with incomplete code.
Change config.ru to the following:
require './config/environment'
if ActiveRecord::Migrator.needs_migration?
raise 'Migrations are pending. Run rake db:migrate to resolve the issue.'
end
run ApplicationController
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.