learn-co-students / sinatra-secure-password-lab-v-000 Goto Github PK

The starter code has an unnecessary route that is not required by the tests. Upon successful login, the test expects to be redirected to the /account route, not /success.
Also, the /account route does not check to see if the user is logged in.

get "/success" do
if logged_in?
erb :success
else
redirect "/login"
end
end

The signup page test for no password given is the same as the test for no username given.

Ok so I was looking at the tests on this lab and noticed currently I can pass without creating a user on sign up.

      post "/signup" do 
	if params.values.any?{|v| v.empty?}
	  redirect '/failure'
	else
	  redirect '/login'
	end
      end

The above code passes because the tests are creating the users for us.

I'd say add a test for sign up that checks if that user was created after filling the sign up form to ensure test doesn't pass with incomplete code.

Missing solution in application controller

Change config.ru to the following:

require './config/environment'

if ActiveRecord::Migrator.needs_migration?
raise 'Migrations are pending. Run rake db:migrate to resolve the issue.'
end

run ApplicationController