learn-co-students / js-principles-scope-chain-code-along-v-000 Goto Github PK

"Understand functions determine scope in Javascript" should be "Understand how functions determine scope in Javascript"

Hello, when I run 'learn' in bash, the console gives an error saying there are no tests available, making it impossible to complete. To fix this, I simply deleted the package-lock.json file and added the following lines in package.json:

"scripts": {
"postinstall": "gem install learn-co",
  "test": "node_modules/browser-sync/bin/browser-sync.js start --config node_modules/learn-browser/bs-config.js"
}

Also, I updated the value of the "learn-browser" key to "^0.1.13".
With that it worked, I just wanted to alert someone of this. I submitted a pull request with these changes (last regarding this: the package.json file seems to have other wrong info in it. Seems like it was copy/pasted from another lesson, but I didn't update that stuff).

Finally, I want to suggest that this lesson should actually be excised from the javascript section, since it is essentially a repeat of the Scope Lab. Thanks for your consideration!

I know this is a 'code-along' so perhaps this is intentional, but all of the code to pass the tests in this lab is provided. The last commit message says 'Copy over existing lesson as a placeholder.'

Issue #44 and comments spell out the issue fairly thoroughly, yet this still remains unaddressed. Students are unable to flag issues to increase visibility. @aviflombaum @jmburges