learn-co-students / js-dom-and-events-konami-code-lab-v-000 Goto Github PK

It seems like in order to pass the tests, you need to almost identically copy the example in the readme.

This includes adding the (event.detail || event.which) logic.

This is very confusing because when you log event.detail it returns 0 for all characters entered so it is not clear why it is necessary.

Additionally, since event.which seems to be depreciated, It might be worthwhile to simply change the code array to a new array containing const updatedCode = ["ArrowUp", "ArrowUp", "ArrowDown", "ArrowDown", "ArrowLeft", "ArrowRight", "ArrowLeft", "ArrowRight", "b", "a"]

This allows for users to use the apparently new standard of event.key instead of which.

Whereas running learn from the terminal does.