learn-co-curriculum / using-active-model-serializer Goto Github PK

the specs for the form
the code along doesn't make it clear why the form is needed

This lab is not testing views, but I added views because the failures/spec were asking for. When you render this through rails s, it shows the form correctly and the form works. However, the following error prints:

1. form shows a new form that submits content and redirects and prints out params
   Failure/Error: fill_in 'title', with: "My post title"
   Capybara::ElementNotFound:
   Unable to find field "title"

"has_many :posts" in author_serializer.rb
worked without generating PostAuthorSerializer and explicitly give it the serializer.

Just like the Returning String Data, DIY JSON Serializer CodealongandUsing to_json, and most likely Receiving API Posts`, I sent an error that none of these turned green for me. Now, the labs have been updated to need the specs to pass.

The specs for these labs are all GENERIC, and exactly the same one. And they need intense revision to basic Rails code in order to make them pass each time. It's time consuming and long. Also, because I already finished these, I am having to go back and try to get Learn to recognize that I had already forked them (because they forgot I forked them), and basically force all these diverse labs to pass the same EXACT spec every time. These should have just been pull request-only, not spec-driven, since these are lessons. Not labs.

Commented out all specs in order to 'pass' and move on to next lab.

I had 2 issues while coding along this lesson:

1. I couldnt bundle install with the version in the Gemfile that I got from forking the lesson.
   Rails v.5 is needed for this lesson.
2. Test spec problem already mentioned in other issues:
   rendering only happened on the json side. There is no html rendering in the controller and no views for that. Test spec expect them though...
   To pass the tests and have the lesson working:
   Change rails gem in the Gemfile to 5 and comment the specs related to view expectations.

Noted paragraph: "And now if we reload our first post show page and click through our Next button we can see that everything works exactly the same as before!"

Issue : This paragraph is particularly confusing for this readme given that the readme directory doesn't actually have a "views" folder. It is also the only mention of the html version of a show page.

Specs missing/incorrect, README needs updates:
#10 #11 #14 #15 #16 #17 #18 #19

Incorrect Error:
#11

README needs updates:
#10

The lesson expects local tests to be run before submitting, but there are not test specs in this lab.

The lesson is about coding API's not about views, but the specs are checking the views, and forms, which was not part of the code-along.

I commented out the it 'shows the title on the show page in a h1 tag' do section and the whole describe 'form' do section to pass the lesson.