learn-co-curriculum / react-hooks-props-basics-lab Goto Github PK

Canvas Link

https://learning.flatironschool.com/courses/4542/assignments/150030?module_item_id=318021

Concern

Running through this lab, I spent a large amount of time trying to figure out why my test were failing despite the output appearing to be correct.

After digging through the tests I figured out that toBeInTheDocument() seems to only return the text content of the HTML tags and not the values of the various attributes. Upon closer inspection of the image on the lesson I do indeed see that it has the 'Links' URLs written out rather than the words 'GIthub' or 'LinkedIn', but I feel failing the tests on this is not really fair as the requirement only stated the links needed to be present.

If it's agreed that this path is a good one to go down, I'm happy to make the PR myself 😄

Additional Context

No response

Suggested Changes

I think a useful tweak would be to change the relevant tests to instead test for the href parameter. I'm definitely no React expert (yet!) but I tweaked the tests to produce what seemed to be what I was after like so:

test("passes 'github' to <Links> as a prop, via <About>", () => {
  const {container} = render(<App />);
  const a = container.querySelector(`a[href="${user.links.github}"`)
  expect(a).toBeInTheDocument();
  expect(a.tagName).toEqual("A");
});

Canvas Link

https://learning.flatironschool.com/courses/4566/assignments/161368?module_item_id=345773

Concern

The test seems to be checking for "username" instead of "name" in the 'About' section of the lab.

The data object has "name" as the key.

The tests check for "username".

Additional Context

No response

Suggested Changes

Change the tests to look for "name" instead of "username" in the 'About' section.

Canvas Link

https://learning.flatironschool.com/courses/5249/assignments/216675

Concern

learn test not registering completion of this lab on Canvas

Additional Context

Students are reporting that, even when tests are passing locally, executing learn test is not marking the lab as complete on Canvas or pushing their solution to their fork on Github.

Suggested Changes

No response