learn-co-curriculum / phase-1-mapping-arrays-readme Goto Github PK

Canvas Link

https://learning.flatironschool.com/courses/4549/pages/mapping-arrays?module_item_id=317835

Concern

const newEngineers = map(oldAccounts, function (account) {

should be

const newEngineers = oldAccounts.map(function (account) {

Additional Context

No response

Suggested Changes

No response

Canvas Link

https://learning.flatironschool.com/courses/5185/pages/mapping-arrays?module_item_id=396141

Concern

In the "Callback city" section we say:
We want to transform values from the array,

This makes me cringe a little. :-(
It implies that we are going to change the values - bordering on manipulating the original values of the array.

Additional Context

No response

Suggested Changes

Maybe soften this:
"We want to transform values from the array, ..."

to something like this?:
"We want to do something with each value from the array, ..."

Language of "each value" highlights how every element from the map will be an input.

Canvas Link

https://learning.flatironschool.com/courses/5185/pages/mapping-arrays?module_item_id=396141

Concern

Technically, this phrase makes grammatical sense:
Let's accept that callback function as the second argument to map():

However, as a reader, my initial reading of those first three words was as:
Let's accept that the sky is blue.

Given this orientation, I had to backup, reread, reconsider, reprocess - all of that, in order to make sense of the sentence.
That's not useful work/mental processing. Can this line be simplified?

Additional Context

No response

Suggested Changes

Instead of:
Let's accept that callback function as the second argument to map():

How about:
So, let's use that callback function as the second argument to map():

or:
So, let's take that callback function as the second argument to map():