learn-co-curriculum / phase-1-control-flow-lab Goto Github PK

Canvas Link

https://flatiron-staff.slack.com/archives/CR07X87PC/p1648592593158789?thread_ts=1648592229.650839&cid=CR07X87PC

Concern

Flagged by @mlgvla in Slack:

Hi - I just helped a student on the current phase-1-control-flow-lab, and noticed that it's missing a range of numbers. This is the current code:

function scuberGreetingForFeet (feet) {
  if (feet <= 400) {
    return 'This one is on me!';
  } else if (1999 < feet && feet < 2500) {
    return "I will gladly take your thirty bucks.";
  } else {
    return "No can do.";
  }
}

There is no condition in for numbers between 400 and 2000. If I were to pass in, say, 500, the it will say "No can do." I don't know, I certainly would take a rider who wanted to travel between 400 and 2000 feet - charge them, maybe $20 or something (based on these rates!)
Would it be possible to add this range to the deliverables and put in a testing condition for it? It might make the logic flow better to a student.

Additional Context

No response

Suggested Changes

No response

Canvas Link

https://learning.flatironschool.com/courses/4985/assignments/163563?module_item_id=351890

Concern

Fork button at my Canvas account does not link me to GitHub account

Additional Context

Fork button at my Canvas account does not link me to GitHub account

Suggested Changes

No response

Canvas Link

https://learning.flatironschool.com/courses/7741/assignments/278298?module_item_id=675984

Concern

To my knowledge, the break is a best-practice use for switch statements to ensure no unintended cases match. This test does not work for the switch if you include a break after each case, but it should still have the same outcome.

I may have a gap in my knowledge here, but I couldn't find anything in the coursework addressing this. If so, please let me know so I do not go on mistaken.

Additional Context

No response

Suggested Changes

No response