learn-co-curriculum / my_find_code_along Goto Github PK

View Code? Open in Web Editor NEW

1.0 19.0 688.0 22 KB

License: Other

Ruby 100.00%

my_find_code_along's People

Contributors

Stargazers

Watchers

Forkers

eric-an mooseboost codebyline dev-learn-co-curriculum bging4 eoghanl elilauff onebusjenny kenkuts tchartchke mimirandi21 smassarsky ggebre rakitzis45 miodice3 gmlevenhagen karegan4 mjones1818 ar00gula spenser6131 jessenreynolds hiddencilantro jcode319 rtblanco bclarke329 bellaappel apontigo nsethblanchard turpp madelinemc ocawthorne yahsei nr598 oroko vmatteucci98 cespino93 fredflor92 tdog088 seanyo89 castanm7 stevens714 marquellboyd22 hovablack anthonyjy72 gundersond graylew1999 hectorfly21 ethanwolfe10 rtyenriques dayshajones angelomilien izzyuri ahmadshahseerat jmacklin1 astralsol gabe31 kingkatraz iamrivera msalerno93 cissica mikemt00 aespinoza777 nathaniel-kerr benjaminghray litatyhq ayo3able piliposyans ikevinzuniga codejavi mchamb92 simonemayers galvezn abysmalpsycho jmsimmons90 davidcampbell00 tahhriq jratana1 nrymarz shilcof cassymarie andrudog7 jomapormentilla nicklevenson bengroves1996 freerunner34 jessijoke rebecca-lindsey garrett-bodley ghemsley brownjer3 georgetalnagi codemama96 gnetboy sandstorm890 sebastianspiegel nmhummel erikn775 hellobontempo jbrasko2 rkredfern

my_find_code_along's Issues

and vs. &&

I noticed that the word 'and' was used in the block of code, and it passed the tests the same as if you used &&.
Example:

def my_find(collection)
i = 0
while i < collection.length
yield(collection[i])
i+=1
end
end

collection = (1..100).to_a

my_find(collection) { |item| item % 3 == 0 and item % 5 == 0}

vs.

my_find(collection) { |item| item % 3 == 0 && item % 5 == 0}

Code typo

Hi, I think you have a typo in step 2 where it says:

As this code executes it will look like this:

def my_find(collection)
i = 0
while i < 100
yield(1)
i = 0 + 1 //here
end
end

At the commented line, I think it should be i = i + 1 rather than i = 0 + 1, which would give you an infinite loop.

Should be a lab

Spec says to return empty array if no match is made, expects nil instead

If you look at the spec, you can see this bit:

  it "returns an empty array when the block condition is not met" do
    expect(my_find(collection) {|i| i % 200 == 0}).to eq(nil)
  end

So, it's suggesting that it returns an empty array [] but expects the return value to be nil.

learn-co-curriculum / my_find_code_along Goto Github PK

my_find_code_along's People

Contributors

Stargazers

Watchers

Forkers

my_find_code_along's Issues

and vs. &&

Code typo

Should be a lab

Spec says to return empty array if no match is made, expects nil instead

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent