leanplum / leanplum-unity-sdk Goto Github PK

The Leanplum SDK depends on several Android libraries that are frequently used by other libraries, which generally leads to version conflicts. A number of SDKs started using the Unity Jar Resolver to fix this issue (for example Facebook SDK). It would be nice if Leanplum would start using this too.

So I ran into this issue, earlier when testing on latest Unity and exporting as iOS/xcode project.
Anyone has quick thoughts on how to fix it? It seems to have todo with Metal Framework, maybe related to new Unity IDE version...

These files cause the ILL2CPP to fail when building from the Unity Editor on the iOS platform in Unity 2017.3.0f3. If you remove them the build will succeed.

Expected Behavior

Requests sent across HTTPS.

Actual Behavior

Some requests sent over HTTP.

Steps to Reproduce the Problem

Specifications

• Version: All SDK Versions
• Platform: Unity, iOS , and Android
• Subsystem:

With Unity 2017.1 we get the following exception whenever Leanplum runs a request:

Failed to decompress data for the AssetBundle 'Memory'.
UnityEngine.WWW:get_assetBundle()
LeanplumSDK.<RunRequest>c__Iterator0:MoveNext()
UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr)

It seems to me that the issue is here:
https://github.com/Leanplum/Leanplum-Unity-SDK/blob/master/LeanplumSample/Assets/WebPlayerTemplates/DoNotCompile/Leanplum/LeanplumUnityHelper.cs#L161-L162

String.IsNullOrEmpty(www.error) && !isAsset ? www.text : null,
String.IsNullOrEmpty(www.error) ? www.assetBundle : null));

should be

String.IsNullOrEmpty(www.error) && !isAsset ? www.text : null,
String.IsNullOrEmpty(www.error) && isAsset ? www.assetBundle : null));

Expected Behavior

iOS displays popup-center window when sending preview message from dashboard

Actual Behavior

iOS native SDK client not recognized when sending preview message from dashboard
dashboard error is "No test devices are connected."
Android works without issues

Steps to Reproduce the Problem

1. create iOS build using with native iOS SDK
2. send preview message from messages dashboard
3. no clients connected error message
4. repeat using android, popup display properly

Specifications

• Version: 1.6.5
• Platform: Unity + iOS
• Subsystem: in-app messaging

We need to exclude alpha, beta versions from the official release builds. Maven includes also the alpha versions of the google libs. Possible solution:

https://stackoverflow.com/a/22174801/2302437

Expected Behavior

When setGcmSenderIds with multiple sender ids, call LeanplumPushService.setGcmSenderIds(senderIds);
with parsed ids(idArray variable)

Actual Behavior

When setGcmSenderIds with multiple sender ids, call LeanplumPushService.setGcmSenderIds(senderIds);
without parsed ids (senderIds is String but Array expected)

Expected Behavior

Unity project builds iOS target without issues

Actual Behavior

use of @import when C++ modules are disabled error during build
setting of Build Settings->Enable the modules (C and Objective-C)->True does not resolve the issue as the header file is being imported by .mm files which are import as Objective-C files and not Objective-C++ files by XCode.

Steps to Reproduce the Problem

1. Import 1.6.5 Unity SDK
2. Build iOS target in Unity
3. Start build in XCode
4. Error occurs

Specifications

• Version: 1.6.5
• Platform: Unity +iOS
• Subsystem: N/A
• XCode Version: 10.1

Expected Behavior

Upgraded from 1.6.0 to 1.6.4 and using xcode 10 + fast lane
Was working on 1.6.0, new version will not code sign

Actual Behavior

2019-02-04 07:30:41 +0000 [MT] Writing entitlements for <IDEDistributionItem: 0x7fccd7391810 'org.cocoapods.Leanplum' '<DVTFilePath:0x7fccd786b1b0:'/Users/jenkins/Library/Developer/Xcode/Archives/2019-02-03/test 2019-02-03 23.26.41.xcarchive/Products/Applications/test.app/Frameworks/Leanplum.framework'>'> to: /var/folders/z1/bqw2_ks13l9fbwq34j3q58hm0000gn/T/XcodeDistPipeline.752/entitlements6N7tUv
2019-02-04 07:30:41 +0000 [MT] Running /usr/bin/codesign '-vvv' '--force' '--sign' 'A77BD1151E6ACCFF3E86E690C6A05BA58ACE304D' '--entitlements' '/var/folders/z1/bqw2_ks13l9fbwq34j3q58hm0000gn/T/XcodeDistPipeline.752/entitlements6N7tUv' '--preserve-metadata=identifier,flags,runtime' '/var/folders/z1/bqw2_ks13l9fbwq34j3q58hm0000gn/T/XcodeDistPipeline.752/Root/Payload/test.app/Frameworks/Leanplum.framework'
2019-02-04 07:30:41 +0000 /var/folders/z1/bqw2_ks13l9fbwq34j3q58hm0000gn/T/XcodeDistPipeline.752/Root/Payload/test.app/Frameworks/Leanplum.framework: replacing existing signature
2019-02-04 07:30:41 +0000 /var/folders/z1/bqw2_ks13l9fbwq34j3q58hm0000gn/T/XcodeDistPipeline.752/Root/Payload/test.app/Frameworks/Leanplum.framework: code object is not signed at all
2019-02-04 07:30:41 +0000 [MT] /usr/bin/codesign exited with 1

Expected Behavior

https://github.com/Leanplum/Leanplum-Unity-SDK/blob/master/LeanplumSample/Assets/LeanplumSDK/SharedConstants.cs#L27 should be updated to current release version to display the correct version within log information

Actual Behavior

Version has not been updates since 1.6.2 making recent updates to later versions very confusing

Expected Behavior

WebGL builds without any problems.

Actual Behavior

Compilation errors when running WebGL build.
Error CS0103 The name 'leanplumSocket' does not exist in the current context

Steps to Reproduce the Problem

1. Download & install Leanplum Unity SDK 4.0.0
2. Switch platform to WebGL
3. Compile project

Specifications

• Version: 4.0.0
• Platform: WebGL

Expected Behavior

iOS target builds without issues or additional settings required

Actual Behavior

XCode build fails with "dyld: Library not loaded" error. This seems to be due to the fact that the .meta file for the iOS framework does not have the "Add to Embedded Binaries" flag enabled. Enabling this seems to have resolved the issue.

Steps to Reproduce the Problem

1. Import 1.6.5 Unity SDK
2. Build iOS target in Unity
3. Start build in XCode
4. Error occurs

Specifications

• Version: 1.6.5
• Platform: Unity +iOS
• Subsystem: N/A
• XCode Version: 10.1