league-of-foundry-developers / fvtt-module-furnace Goto Github PK

Lines 17-18 of Patches.js incorrectly add an extra "function" string to the beginning of an async function, which then gets swapped around by lines 19-20 to read "async function function". Line 17 should be revised as follows:

- if (!fixed.startsWith("function"))
+ if (!(fixed.startsWith("function") || fixed.startsWith("async function")))

I thought this already existed, but maybe I was mistaken; no combination of CTRL/SHIFT/ALT I use seems to disable snapping.

As per title, some hotkey that could be held to disable grid snap (especially with the freehand tool, where only the initial point seems to snap) would be appreciated.

things like drawing frame, config UI, etc...

Furnace 1.4.1, Foundry 0.53, Advanced Macros turned on.

When anyone uses [[dice]] from monster attacks to roll, critical totals are not colored in red or green. They will become colored on Foundry reload.

was using furnace today and realized trusted players are unable to use the text tool. Console throws "uncaught exception: You do not have the ability to configure a Drawing object." Confirmed every other drawing type works fine for trusted players just not text.

Suggestion from @dacaz5, have the header copied into each new entry instead of separate on its own journal.

an empty line with the heading will cause the new journal name to be an empty string which is not accepted, so creation fails.

Furnace QOL suggestion - When someone starts a playlist and not a stand alone song, have it also move the playlist heading up to the top as well. Example when I play this playlist in simultaneous mode: http://prntscr.com/qrqfcq

it moves everything but the header up, and to turn the entire list off you have to hit stop on the header as shown here. http://prntscr.com/qrqger

in short please consider also moving the playlist name bar up with any song that plays,

Test Info (latest everything): Foundry 0.6.0 on Windows 10 self hosted (electron app as GM), DND5e 0.92, Powercards 0.0.7, Furnace 1.8.

I am attempting to use Sky's not-officially-distributed Powercard's module (https://github.com/Sky-Captain-13/foundry/tree/master/powercards). When a specially formatted chat macro (not script) is run, it generates a shiny powercard for the output:

!power {{
--emote|Surprise, MFer.
--title|Surprise
--title_fontsize|1.5em
--title_txcolor|#FFFFFF
--title_bgcolor|#8B0000
--subtitle|Ranged * Range (80/320)
--Attack:|[[1d20 + 4]] | [[1d20 + 4]] vs AC
--Damage:|[[2d6+6d6+4]] critical hit piercing damage
}}

Is supposed to turn into this in the Chat Log:

Without The Furnace's advanced macros enabled, this works as intended. However, if I check the Advanced Macros configuration, I instead get this error for the same macro:

After talking with Sky, he's indicated that it's out of the scope of his module to fix this issue.

I have two questions for you:

1. Is the Advanced Macros supposed to be parsing chat macros at all?
2. If it is, is it possible for The Furnace to not parse any chat macros that start with "!power"?
3. Is it possible to rewrite that Powercard macro in a way that The Furnace will not hate it?

Thanks!! Any help would be greatly appreciated :(

Resizing a text loses aspect ratio, being able to reset the size of the drawing to match the font size would be nice.

If a token is emitting tinted light, it's not visible for the GM if token vision is disabled.

This seems like a PIXI v5 bug. There's some conflict between the fill and texture opacity.

Add an option on handouts to split them into multiple smaller ones. This can be useful for R20 modules that have one handout with all the room descriptions, it would be nicer to have it all spread out into separate handouts for easier access.
Also, would make it easier to drop pins onto rooms.

https://bitbucket.org/Fyorl/obsidian/issues/100/inventory-wont-update-amount-of-items

This incompatibility has been found in Obsidian and it looks to be an issue in how Furnace handles it.

From Tielc: https://streamable.com/dazon

canvas.drawings.options.controllableObjects = true

drop folder of actors on the canvas to drop all of their tokens.

game.tables.entities.find(e => e.id === "id").draw();

Things like bold/italic, maybe even dropshadow stuff...
https://pixijs.download/v4.5.2/docs/PIXI.TextStyle.html

if there's ambient sound in the scene, a GM selecting a token will start hearing it.
Like the 'hide token vision' option for GM, we should be able to mute token hearing too.

Having some of the useful scripts that don't work as actual feature be available in a macro compendium would be great.
Examples:

• check distances :

let message = ""
for (let token of canvas.tokens.controlledTokens) {
   let ruler = canvas.controls.ruler;
   for (let target of game.user.targets) {
       ruler.clear()
       ruler.waypoints.push(token.center)
       ruler.labels.addChild(new PIXI.Text(""));
       ruler.measure(target.center);
       let distance = ruler.labels.children[0].text;
       message += `From '${token.name}' to '${target.name}' : ${distance}<br/>`
       ruler.clear();
   }
}
if (message) {
   ChatMessage.create({content: message, whisper: [game.user.id]});
}

• print/find id of entities

• auto configure tokens

let tokens = []
for (let token of canvas.tokens.placeables) {
   tokens.push({_id: token.id, "bar1.attribute": "attributes.hp", "bar2.attribute": "", "displayName": CONST.TOKEN_DISPLAY_MODES.OWNER, "displayBars": CONST.TOKEN_DISPLAY_MODES.OWNER})
}

if (tokens.length > 0)
  canvas.scene.updateManyEmbeddedEntities('Token', tokens)

When I have a journal entry in a folder and I close it, that journal entry is removed from the folder. Expected behavior is that it stays in the same folder.

having a message whispered to the triggering player makes a lot of sense, and would be better than just whispering to the GM

Is it possible to add interface for registering web fonts from Google for use in the font dialog in the drawing tool. The idea is to be able to use a lot more font, especially decorative ones, rather than the few serif or non-serif classic options in the platform today.

It also breaks all the drawings it seems because migration stops ?

Happened in my CoS game. I had a few drawings, I couldn't see two of them, Alt on drawings layer didn't show them either. freehand and text drawings. Switched to a different scene and back and they were there.
Can't reproduce.

It appears when I turn on The Furnace it interferes with my ability to make, format, or delete text boxes.

From @BrotherSharp :

Here's some stuff for music that I had in mind

• Soundboard, where you can bind keys to SFX to play them or a UI to bind SFX alongside icons to play them on click. It immensely help because it is hard to find a SFX under a long list.
• Manual startpoints/endpoints. Some music fades away, but you can create artificial loops by setting an endpoint.
• In regards to the above credits, a way to set credits for the entire playlist or for the individual song, with the individual one taking priority over the playlist one.
• Ability to allow trusted players to take control of the music panel. They can help you by playing their character's theme music while you are fumbling around finding a certain actor/handout.
• Ability to allow trusted players to upload music. If possible alongside sources.
• Link with dropbox or any other online storage places

These are just off the top of my head, all I can do being a shitter at implementing any of these 🤣

macros.js line 216

                await this.renderContent(...args);

should be

                return await this.renderContent(...args);

also this in the console:

foundry.js:39097 Uncaught TypeError: Cannot read property 'data' of null
    at ActorDirectory._onDragStart (foundry.js:39097)
    at DragDrop.callback (foundry.js:13673)
    at DragDrop._handleDragStart (foundry.js:13699)

as soon as you start dragging the folder.