[BUG] Rofi window mode does not seem to work anymore in Hyprland about rofi

[alebastr]

#118

I haven't tested on Hyprland, it may require full wl_display_roundtrip in display_surface_unmap to make the compositor aware that the surface is unmapped.

[LorenzoBettini]

I'm afraid I can't help from the implementation point of view, but I can test possible fixes in case you come up with something.

[lbonn]

@LorenzoBettini if it's another regression on hyprland side, I see no need to track it here.

In case rofi-wayland need some changes to work on hyprland again (does not seem to be the case so far?), I would prefer opening another separate issue as this particular one has been resolved already and it quickly gets confusing to talk about two similar bugs with different root causes in the same discussion thread.

[LorenzoBettini]

Hyprland version: hyprland 0.35.0-2 in Arch Linux

[lbonn]

Thanks, I have just tried (on Hyprland latest git revision) and it looks indeed broken.

This should be filed in Hyprland issues IMO: activate in wlr-foreign-toplevel-management stopped working between 0.34 and 0.35?

[LorenzoBettini]

@lbonn do you plan to report it yourself? Maybe you have more knowledge of the involved low-level mechanisms. I could only guess about wmctrl, but maybe that's not even related to the problem?

[lbonn]

@LorenzoBettini ok, done. I don't use Hyprland myself, if they are asking for more version details or testing, maybe you can assist at hyprwm/Hyprland#4829 :)

[LorenzoBettini]

@lbonn thanks. They've already answered in that issue but I seem to understand they mention a new procedure that must be implemented in the window mode of rofi, right?

[lbonn]

Yes, rofi is taking keyboard focus and we activate the target window before releasing the focus. It's not something that's really specified as far as I know but I also don't see why it should be such a problem in practice (would have to look into it).

Releasing the keyboard interactivity before activating the window would complicate things a bit.

likely hyprwm/Hyprland@17339e0

you need to:

unmap your ls
then issue an activate
then do whatever else and exit

if you issue an activate while you still have a keyboard-exclusive LS open, it will be ignored.

@alebastr any thoughts on this?

[alebastr]

This seems surprisingly easy to implement: XCB window mode calls rofi_view_hide before activating the selection. And since XCB already behaves that way, it's not unreasonable to adjust the Wayland code.

We could add the missing implementation for wayland_rofi_view_hide and do the same in wayland-window.

[LorenzoBettini]

I'm afraid we should re-open this, since the problem shows up again in Hyprland 0.40. I've already raised an issue on Hyprland because it also happens in other programs changing the window: hyprwm/Hyprland#6236