lazoyoung / craftgames

Minecraft Paper plugin that enables you to make custom minigame scripts.

craftgames's Issues

Some players are not counted during game.

It's happening in certain circumstances:

1. Joins a game where map generation is still in progress.
2. The other players who has joined next to you are not counted.
   Basically they are treated like being outside the game.

Allow scripts to manage world time.

module controlling minecraft world time
(add time/set time)

Vanilla death message / Read Death cause

dd

Restore inventory, game mode

They need to be restored when a player leaves game.

Player module

• Send message to player. (formatting code ready)
• Get players by 3 filters: all, team, dead.
• Check if player is online(inside game).
• Eliminate a player.
• Kill, Death trigger -> #24

Unable to call functions in Bukkit objects

Provide sample/preset scripts

• Sample script is for new users.
• Preset scripts let users to generate particles, fireworks, etc. easily compared to using Bukkit API directly.

Lobby module

• Spawnpoint
• Timer
• Map vote
  • /mapvote system
  • Vote menu
• Exit mode
  • World (in-server)
  • Server (bungeecord-bound)
• Ready sign

/ctag capture requires Editor mode implementation

• Enter the editor mode via /game edit <title> <mapID> for each map.
• Save the world and leave editor mode via /game save.
• Captures are stored inside the editor's memory.

Another option instead of default spawn coordinate after finishing game

option to go back to exact last location(where player issued /join command) when player leaves the game in any condition(including forced server exit)

Default fallback location for leaving game.

It is defined in config.yml

Team module

• Create a Team instance
• Draw a fixed number of players and assign them to a team
• Get list of players who are in a team
• Provide Scoreboard instance
• Spawnpoint per team

Lobby world is not peaceful.

• Make all the players invulnerable.
• Stop monsters from spawning by ticking on peaceful mode.

Mob module

• 몹 스폰하기
• MythicMob 스폰하기
• 몹 타입 확인하기

Location serialization is not safe.

Plugin must save the location of game players so they can exit back to the original place.
The code relies on Bukkit method when it comes to saving
location to file and vice versa. If the world is unloaded at that point, the server crashes.

Reaching EOF while reading kit data.

If no potion effect is applied to a kit, reading its size throws EOF Exception.

/ctag remove doesn't work for some reason.

The tag doesn't get removed after saving the modifications.

MythicMobs compatibility issue

This error occurs in MythicMobs plugin's task execution.
I presume this plugin has to remove MythicMob entities before deleting world.

[00:34:54 ERROR]: [MythicMobs] [SCHEDULER] Exception thrown whilst executing task
[00:34:54 WARN]: java.lang.NullPointerException
[00:34:54 WARN]:        at io.lumine.xikage.mythicmobs.drops.LootBag.equip(LootBag.java:201)
[00:34:54 WARN]:        at io.lumine.xikage.mythicmobs.mobs.MythicMob.lambda$applyMobOptions$2(MythicMob.java:857)
[00:34:54 WARN]:        at io.lumine.xikage.mythicmobs.utils.Delegates$RunnableToSupplier.get(Delegates.java:95)
[00:34:54 WARN]:        at io.lumine.xikage.mythicmobs.utils.promise.LuminePromise$SupplyRunnable.run(LuminePromise.java:653)
[00:34:54 WARN]:        at io.lumine.xikage.mythicmobs.utils.tasks.LumineExecutors$SchedulerWrappedRunnable.run(LumineExecutors.java:71)
[00:34:54 WARN]:        at org.bukkit.craftbukkit.v1_15_R1.scheduler.CraftTask.run(CraftTask.java:84)
[00:34:54 WARN]:        at org.bukkit.craftbukkit.v1_15_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:452)
[00:34:54 WARN]:        at net.minecraft.server.v1_15_R1.MinecraftServer.b(MinecraftServer.java:1185)
[00:34:54 WARN]:        at net.minecraft.server.v1_15_R1.DedicatedServer.b(DedicatedServer.java:430)
[00:34:54 WARN]:        at net.minecraft.server.v1_15_R1.MinecraftServer.a(MinecraftServer.java:1112)
[00:34:54 WARN]:        at net.minecraft.server.v1_15_R1.MinecraftServer.run(MinecraftServer.java:934)

Display remaining time until respawn.

This is requested by jupiter1390.

Security measure for groovy scripts

This is due to the following security concerns:

• Scripts may access sensitive files. e.g. system file
• It's possible to mess up a whole server with unlimited commands.

Lots of player status gets reset after game

Potion Effect, Health, Exp, and etc options

World module

• Install schematics
• Barrier controls
• Area triggers
• Fill loot chests

Ability to lock inventory

1. disallow players to throw items out of inventory
2. disallow players to modify inventory(moving items or etc)

Players cannot edit any map that has missing coordinate captures.

Area display render distance

is too short.

Illegal characters in script disrupt Groovy to resolve function.

• Some modules are out of scope from inner closures. pastebin Because script bindings were cleared at the moment.
• For some reason, Groovy can't resolve methods for Bukkit Object. pastebin

Script module

• 이벤트: 버킷 이벤트를 모니터링하는 함수를 등록한다.

이벤트 모듈로 분리합니다.

• 스케줄러: 어떤 시점에서 일련의 코드를 일정 주기로 반복 실행하거나, 지정된 시간에 맞추어 실행하는 기능을 제공한다.

Deprecate Triggers

• Replace triggers with Bukkit events.
• Rewrite documentation.

Game module

• Personal spawnpoint
• Editor spawnpoint
• Spectator spawnpoint
• Default Gamemode
• Respawn timer
• Game timer
• Broadcast message to players. (formatting code)
• Player capacity
• Decide whether to keep it open for players after the game starts.

Item module

• Reading loot table JSON
• Kits
  • Allow/deny kit selection
  • Force players to wear a kit.
• Inventory restoration moved to #38

Check Entity existence

1. Able to check Entitytype(mob type) and Name

2. Association with Area; if not associated with area it will check every entities in game world

3. Check entity number

Void damage Error

When player die with void damge, they will still take void damage for a while when respawned

Plugin fails to unload a world if it loses track of the players inside.

Unable to spawn mobs right after GameStartEvent.

GameModule#spawnMythicMob() has no effect when it's called inside GameStartEvent.

Option to keep inventory on death.

• Keep inventory/exp on death
• Drop items/exp on death

Suggested by jupiter1390.

Accessibility module

• 파티 단체참여를 허용한다. 정원을 초과하면 남은 인원은 관전시킨다.
• (optional) 다른 서버에서 접속한 유저를 바로 미니게임으로 이동시킨다.

Dispersed spawnpoint

This is requested by jupiter1390.

Disable item interactions in spectator mode

some plugin items are known to work in spectator mod(ex: QualityArmory guns)

Allow script to utilize schematics.

Reward prompt menu

Prevents possible overflowing inventory after receiving reward items.

Spawn module

• Personal spawnpoint
• Editor spawnpoint
• Spectator spawnpoint
• Mob spawn function
  • Vanilla mob support
  • Mythic mob support

Allow multiple editors in sole map.

Plugin fails to install sample files.

Implement coordinate tags

Refer to wiki for details.

• Coordinate is sorted into block and entity type. (They have different usage)
• A tag defines coordinate in either type, holding at least one value per each map.
• Can be managed via command: /game tags <add/remove/list> [group] [type] [index]
• #9 fix must precede.

Install and manage the running maps

• Install map files from game repository.
• Generate maps quickly without impacting performance.
• Destruct map files after the game is finished.

Map generation is too slow compared to lobby.

Spawn pvp protection

This includes both situation when you first spawn inside a game, when you have just respawned after getting murdered.
It is configurable in config.yml only.

cannot spawn mobs using Game Start Event

cannot spawn directly after; giving delay will work though

Respawn module

Migrate some existing functions from PlayerModule.

// Initial spawnpoint
RespawnModule.setSpawnpoint(String tagName)
RespawnModule.setSpawnpoint(Player player, String tagName)

// Respawn position (optional)
RespawnModule.setRespawnpoint(String tagName)
RespawnModule.setRespawnpoint(Player player, String tagName)

// Respawn toggle
RespawnModule.setCanRespawn(Boolean canRespawn)
RespawnModule.setCanRespawn(Player player, Boolean canRespawn)

1. If you have never invoked setRespawnpoint():
   Players are relocated to initial spawnpoint whenever they respawn.

2. If you invoke setRespawnpoint() with relevant tagName argument:
   The new spawnpoint is set for the respawning players.

3. If you invoke setRespawnpoint() while passing null to tagName argument:
   The new spawnpoint is where you were killed last time.

Reward functions in ItemModule

This module is responsible for distributing rewards among players after the game's finished.

• Set money reward for each player/team
• Set ItemLoot reward for each player/team