Comments (3)
TLDExtract uses TLDDatabase which uses PublicSuffix List as single source of truth. PSL has two sections: ICANN and private domains. So, when you set TLDExtract's parsing mode it operates with determined sections.
blogspot.com
is defined in private section, so it's private domain. If don't need private domains in your result, you need to set parsing mode:
$extract = new Extract(null, null, Extract::MODE_ALLOW_ICCAN);
$result = $extract->parse('test.github.com');
// of in fuction
tld_extract('test.github.com', Extract::MODE_ALLOW_ICCAN);
Howerer, I agree that getRegistrableDomain()
returns an incorrect result without parsing options, it's a priority issue for next major version.
from tldextract.
hi,
there are also some other domains falsley valid.
ex.: #test.com or test.com#test_test
->isValidDomain() gives me true for both, and also in the ->getRegistrableDomain() i get the false domain
regards
from tldextract.
@dgram Thanks, I opened #15 for this.
from tldextract.
Related Issues (20)
- Errors extracting from some subdomains HOT 1
- Extract registerable domain returns empty HOT 3
- test..com is valid domain HOT 2
- isValidDomain returns true for domains that are too long HOT 1
- underscore in hostname HOT 5
- Should getSubdomains return an empty array if no subdomains found? HOT 3
- local file being interpreted as a tld
- app_dev.php is a valid domain HOT 1
- Support PHP 5.4.0 for version 0.2.0 HOT 1
- Underscore at end of hostname label causes parsing to fail HOT 1
- Make Extract::suffixExists protected HOT 2
- Incorrect Parsing of Malicious Payload
- TLD for domain test.ru is not recognized HOT 2
- Replace punycode with the symfony polyfill
- Uncaught OutOfRangeException HOT 3
- Parser bug when subdomain has "-" HOT 1
- https://youtube.comxyzh is a valid domain HOT 1
- "@" symbol should not be allowed in domain name
- RFC
- TLDExtract not properly parsing hostname HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tldextract.