Coder Social home page Coder Social logo

Comments (2)

layershifter avatar layershifter commented on May 29, 2024

There is no issue with the package, test.ru and others are marked as reserved in the ICANN section of Public Suffix List: https://github.com/publicsuffix/list/blob/6f2b9e75eaf65bb75da83677655a59110088ebc5/public_suffix_list.dat#L5884

So, even Extract::MODE_ALLOW_ICANN will not help you there, php-domain-parser has a same issue there because it uses the same database. However, test.ru should be suffix in this case.

from tldextract.

skeets23 avatar skeets23 commented on May 29, 2024

Wouldn't this be fixed by changing the code here (line 225-227 of Extract.php)

        if ($suffix === $hostname) {
            return [null, $hostname, null];
        }

to this:

        if ($suffix === $hostname) {
            return [null, null, $hostname];
        }

?

Is there a reason the suffix is being placed in the "hostname" when there's just a suffix?

You can still work around it, I suppose, since the TLDDatabase library is a dependency, you can just use that pacakge to check if the string is a public suffix first.

from tldextract.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.