Comments (2)
There is no issue with the package, test.ru
and others are marked as reserved in the ICANN section of Public Suffix List: https://github.com/publicsuffix/list/blob/6f2b9e75eaf65bb75da83677655a59110088ebc5/public_suffix_list.dat#L5884
So, even Extract::MODE_ALLOW_ICANN
will not help you there, php-domain-parser has a same issue there because it uses the same database. However, test.ru
should be suffix
in this case.
from tldextract.
Wouldn't this be fixed by changing the code here (line 225-227 of Extract.php
)
if ($suffix === $hostname) {
return [null, $hostname, null];
}
to this:
if ($suffix === $hostname) {
return [null, null, $hostname];
}
?
Is there a reason the suffix is being placed in the "hostname" when there's just a suffix?
You can still work around it, I suppose, since the TLDDatabase library is a dependency, you can just use that pacakge to check if the string is a public suffix first.
from tldextract.
Related Issues (20)
- Errors extracting from some subdomains HOT 1
- Extract registerable domain returns empty HOT 3
- test..com is valid domain HOT 2
- isValidDomain returns true for domains that are too long HOT 1
- underscore in hostname HOT 5
- Should getSubdomains return an empty array if no subdomains found? HOT 3
- local file being interpreted as a tld
- app_dev.php is a valid domain HOT 1
- Support PHP 5.4.0 for version 0.2.0 HOT 1
- Underscore at end of hostname label causes parsing to fail HOT 1
- Make Extract::suffixExists protected HOT 2
- Incorrect Parsing of Malicious Payload
- Replace punycode with the symfony polyfill
- Uncaught OutOfRangeException HOT 3
- Parser bug when subdomain has "-" HOT 1
- https://youtube.comxyzh is a valid domain HOT 1
- "@" symbol should not be allowed in domain name
- RFC
- TLDExtract not properly parsing hostname HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tldextract.