Coder Social home page Coder Social logo

Comments (6)

larrymyers avatar larrymyers commented on June 27, 2024

There are plenty of cases in getHref where it will return undefined instead of the url. This is to prevent the router from intercepting links that point to external resources instead of registered routes.

Can you provide a working example where this fails?

from react-mini-router.

kkarimi avatar kkarimi commented on June 27, 2024

Yes sure, I think my issue is that all links are considered as external for some reason, maybe I have set it up wrong?
So here is my code:
https://github.com/kkarimi/react-mini-router-IE8-test
and I have put up the build here:
https://kkarimi.github.io/react-mini-router-IE8-test
Visiting the page in real IE8 under virtualbox shows the problem (links don't work).

from react-mini-router.

larrymyers avatar larrymyers commented on June 27, 2024

Looks like it may be due to RouterMixin.js line 182, with IE 8 not having a target property on Event, but instead srcElement. I should have some time this week to get a fix tested and pushed to npm.

from react-mini-router.

kkarimi avatar kkarimi commented on June 27, 2024

I believe you are right about the srcElement on IE8, a fix release would be great, many thanks.

from react-mini-router.

larrymyers avatar larrymyers commented on June 27, 2024

Fixed. 1.1.7 published to npm and bower.

from react-mini-router.

kkarimi avatar kkarimi commented on June 27, 2024

Thanks Larry, although I did a quick test and it did not seem to work out of the box, I will run it through debugger and get back to you tomorrow.

from react-mini-router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.