Comments (6)
There are plenty of cases in getHref where it will return undefined instead of the url. This is to prevent the router from intercepting links that point to external resources instead of registered routes.
Can you provide a working example where this fails?
from react-mini-router.
Yes sure, I think my issue is that all links are considered as external for some reason, maybe I have set it up wrong?
So here is my code:
https://github.com/kkarimi/react-mini-router-IE8-test
and I have put up the build here:
https://kkarimi.github.io/react-mini-router-IE8-test
Visiting the page in real IE8 under virtualbox shows the problem (links don't work).
from react-mini-router.
Looks like it may be due to RouterMixin.js line 182, with IE 8 not having a target property on Event, but instead srcElement. I should have some time this week to get a fix tested and pushed to npm.
from react-mini-router.
I believe you are right about the srcElement on IE8, a fix release would be great, many thanks.
from react-mini-router.
Fixed. 1.1.7 published to npm and bower.
from react-mini-router.
Thanks Larry, although I did a quick test and it did not seem to work out of the box, I will run it through debugger and get back to you tomorrow.
from react-mini-router.
Related Issues (20)
- Pre route hook HOT 1
- Support React 0.14 HOT 15
- Opening link in new tab does not respect hash-bang HOT 4
- Prototype a RouterComponent to wrap Component HOT 2
- navigate() does not respect root configuration value HOT 2
- Ability to prevent default from React's `onClick` Handler HOT 1
- Back button HOT 2
- Passing parameter as part of a link HOT 1
- Is it possible to execute redirections? HOT 2
- Hash-bang urls in ^2.0.0 clears out some url information HOT 2
- does this support in page or hash links? HOT 6
- search params error on the wechat app HOT 2
- The Router Challenge
- 2 different versions in dist HOT 2
- how to access POST data? HOT 2
- Incompatible with React 15.4.0 HOT 1
- Looking for Project Maintainers HOT 5
- Update NPM package HOT 1
- React 16 support HOT 4
- navigate('/foo', true) does not disable routing
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-mini-router.