Comments (15)
I'm guessing this has to do with the separation of react and react-dom for 0.14.
I don't have a ton of time to devote to this issue immediately, so a pull request to get this library supported with 0.14 would be welcome.
from react-mini-router.
All you should have to do is require('react-dom')? Or am I mistaking something.....
from react-mini-router.
I've tracked down where the functions from React that RouterMixin have moved to, though I'm still in the process of cleaning up all the tests and the example app. It's not a straight forward process since the team at Facebook have broken a few things from a compatibility standpoint.
from react-mini-router.
Yep, @larrymyers any estimation when you might finish making it compatible? Thanks!
from react-mini-router.
No estimate right now. There are still errors in the example app, and I haven't done any cross browser testing yet. @ykka Any help would be welcome. Just check out the react-0.14-upgrade branch.
from react-mini-router.
I might do actually, I've just ditched the react-router
... mini-router
gives me much more flexibility I think.
I might look into it over the weekend if I find time.
from react-mini-router.
react-mini-router is just great compared to the monstrous react-router.
A very simple fix is to introduce a dependency to fbjs package, where they moved the EventListener.js module to, and fix corresponding require in the RouterMixin.js like this:
EventListener = require('fbjs/lib/EventListener'),
I am just testing the result, but it seems to work as expected. Please share your thoughts, maybe it's just pure magic.
UPDATE: I just found out that there is a react-0.14-upgrade branch where this stuff is going
from react-mini-router.
Hey, so @bragin (@larrymyers) to me it seems to work, any chances of merging it to master
soon?
from react-mini-router.
Actually, I was wrong, it does seem to fail in my project. So I am not sure if it works or not.. I don't have enough time to look into it atm, sorry!
from react-mini-router.
Todo for 0.14 Support:
- Fix bugs in example app.
- Run tests across Chrome, Safari, Firefox, IE 11, and IE 9
- Verify compatibility with 0.12 and 0.13, or determine if this release will be 2.0.0
- Update changelog and readme
from react-mini-router.
Any progress on this?
from react-mini-router.
The day job has me almost completely occupied right now. I'd welcome any help by having pull requests target the react-0.14-upgrade branch.
from react-mini-router.
I have fixed the bugs in example app and made a pull request #49 . I have tested in Safari, Firefox and Chrome and it works fine!
react-mini-router is not compatible to react 0.12 or 0.13 because it has a dependency to react-dom. So I guess this would be a 2.0.0 release?
The update needed in the Readme would only be the requirement to React 0.14.
from react-mini-router.
@jakoblind I agree, a major version bump to 2.0.0 seems like the right decision due to the new dependency on react-dom. Your pull request is merged, so I'll get things ready for release on master and get 2.0.0 pushed out to npm.
from react-mini-router.
react-mini-router 2.0.0 is live on npm with support for React 0.14. Thanks to @jakoblind for doing all the heavy lifting.
from react-mini-router.
Related Issues (20)
- Pre route hook HOT 1
- Opening link in new tab does not respect hash-bang HOT 4
- Prototype a RouterComponent to wrap Component HOT 2
- navigate() does not respect root configuration value HOT 2
- Ability to prevent default from React's `onClick` Handler HOT 1
- Back button HOT 2
- Passing parameter as part of a link HOT 1
- Is it possible to execute redirections? HOT 2
- Hash-bang urls in ^2.0.0 clears out some url information HOT 2
- does this support in page or hash links? HOT 6
- search params error on the wechat app HOT 2
- The Router Challenge
- 2 different versions in dist HOT 2
- how to access POST data? HOT 2
- Incompatible with React 15.4.0 HOT 1
- Looking for Project Maintainers HOT 5
- Update NPM package HOT 1
- React 16 support HOT 4
- navigate('/foo', true) does not disable routing
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-mini-router.