Comments (9)
Can you get me some more details so I can reproduce?
- Are you navigating to a url not handled by the router?
- Is the componentWillUnmount lifecycle method not being called on the component you're adding the RouterMixin to?
If the DOM tree isn't changing, then the event listener shouldn't be lost.
from react-mini-router.
Ah, that's good to know - perhaps I'm inadvertently doing something a bit strange then!
Let me see if I can reduce it down to a test case that I can share, then. I'll post an update here soon.
from react-mini-router.
Any updates on what the issue was?
from react-mini-router.
Sorry for the delay, Larry. Just trying to build a little test case now. Hope to post it here tonight or tomorrow.
from react-mini-router.
OK, here is a quick test case: https://github.com/poshaughnessy/react-mini-router-test
NB. I used a standalone version of your library, that I made using browserify
on the command line, because:
- I didn't want to introduce a CommonJS compile step, for this simple test case
- I tried installing it with
bower
, but it errored with:ENOTFOUND Package juliangruber/isarray=juliangruber/isarray not found
?
Instructions / steps to reproduce the problem (also included in the README):
npm install
node server
- Fire up
localhost:3000
in the browser - (Bring up the Network tab in the debugging tools so you can see when a full page request is made)
- Click
Page one
- this will load without a full page request - Click
Page two
- this now causes a full page request
Tested in Chrome v40 and Firefox v35.
Hope this helps!
from react-mini-router.
@poshaughnessy Thanks! That will be extremely helpful in debugging. I've attached this issue to the 1.1 milestone, so expect to see it resolved this month.
from react-mini-router.
There is actually a very simple workaround, at least for us it worked well - wrap the component produced by the route function (that is different for each route) into a <div>
- which will get the listener attached to itself, does not change, and thus doesn't lose the listeners.
I.e. instead of
render: function() {
return this.renderCurrentRoute();
},
do this
render: function() {
return (<div>{this.renderCurrentRoute()}</div>);
},
in your root component with the RouterMixin
.
from react-mini-router.
I ran into this issue today. @jakubholynet 's solution worked.
from react-mini-router.
Still running into this, @jakubholynet's solution helped me out! Thank you. @larrymyers it'd be awesome if this was noted on the README if the code fix is a little ways off!
from react-mini-router.
Related Issues (20)
- Pre route hook HOT 1
- Support React 0.14 HOT 15
- Opening link in new tab does not respect hash-bang HOT 4
- Prototype a RouterComponent to wrap Component HOT 2
- navigate() does not respect root configuration value HOT 2
- Ability to prevent default from React's `onClick` Handler HOT 1
- Back button HOT 2
- Passing parameter as part of a link HOT 1
- Is it possible to execute redirections? HOT 2
- Hash-bang urls in ^2.0.0 clears out some url information HOT 2
- does this support in page or hash links? HOT 6
- search params error on the wechat app HOT 2
- The Router Challenge
- 2 different versions in dist HOT 2
- how to access POST data? HOT 2
- Incompatible with React 15.4.0 HOT 1
- Looking for Project Maintainers HOT 5
- Update NPM package HOT 1
- React 16 support HOT 4
- navigate('/foo', true) does not disable routing
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-mini-router.