SQLite issue with default 0 columns when migrating db from schema dump since L11 upgrade about framework

[staudenmeir]

/cc @hafezdivandari

[staudenmeir]

Hi @adiachenko,
Did you log and compare the Schema::create() queries between Laravel 10 and 11?

[adiachenko]

I went through our migrations one by one and managed to distill some sort of example to replicate the issue.

Assume we have the following SQL schema dump file:

CREATE TABLE partners (
  id INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL,
  support_priority INTEGER DEFAULT 0 NOT NULL,
);

Then we have the following 2 migrations to run on top of that file:

Schema::table('partners', function (Blueprint $table) {
    $table->unsignedSmallInteger('partner_type')->nullable();
});

Schema::table('partners', function (Blueprint $table) {
    $table->unsignedSmallInteger('partner_type')->default(0)->change();
});

When running the second alter table statement Laravel 11 will execute the following queries:

create table "__temp__partners" (
  "id" integer primary key autoincrement not null,
  "support_priority" integer not null,
  "partner_type" integer not null default '0'
);

drop table "partners";

alter table
  "__temp__partners" rename to "partners";

Note how support_priority is now just not null somehow without any default.

After I manually replaced default 0 with default '0' in schema dump it generated a correct query.

create table "__temp__partners" (
  "id" integer primary key autoincrement not null,
  "support_priority" integer not null default '0',
  "partner_type" integer not null default '0'
)

However, I do not like this "fix", because it will be overridden each time I recreate SQL dump meaning I will need to manually change all of these again.

[hafezdivandari]

@staudenmeir thank you for mentioning me.

The issue seems to be on the following line, causes default 0 to be null:

framework/src/Illuminate/Database/Schema/Grammars/SQLiteGrammar.php

Line 275 in b3db6b6

'default' => $column['default'] ? new Expression($column['default']) : null,

I'm on vacation until Friday, and can't send a PR till then.

[github-actions]

Thank you for reporting this issue!

As Laravel is an open source project, we rely on the community to help us diagnose and fix issues as it is not possible to research and fix every issue reported to us via GitHub.

If possible, please make a pull request fixing the issue you have described, along with corresponding tests. All pull requests are promptly reviewed by the Laravel team.

Thank you!

[sinarahmany]

A possible workaround is to manually update the schema dump to use DEFAULT '0' instead of DEFAULT 0. However, this isn't ideal as it requires manual intervention each time the schema dump is recreated.

I suggest opening a pull request to address this issue in SQLiteGrammar.php.

[hafezdivandari]

You may check PR #51803