Comments (13)
Hi @driesvints, indeed, I had the same issue with classes.
I added another failing test case with a simple class in the PR #51878.
from framework.
I confirm that I don't have the problem in my project with this fix!
from framework.
The issue I have with chained batches is that they stop executing whenever I have a job that uses a class type for its properties.
As soon as the next job in a chained batch has a class property, the chain is removed from the queue and marked as completed.
I've tried many combinations of visibility, readonly, promoted properties, non-promoted properties, serialising and unserialising the classes myself
Nothing seems to work, other than removing the properties.
All the jobs/batches in the chain are correctly displayed in the payload in both the Redis and database drivers.
from framework.
I tried a quick and dirty test: I added the if statement in the Native.php file modification in the vendor.
I'll try it directly in my project using your version of laravel/serializable-closure.
from framework.
Same here. Seems like it actually fixes the problem.
I tested on the state I left things in a couple weeks ago, but definitely works now.
I first tested without installing @rust17 branch, and it still failed.
After installing the branch, it now goes through a chain of 10 batches, most of which use class properties- and arguments.
I'm gonna reset all my changes I did while debugging, but I'm confident this does solve it altogether.
from framework.
Hey @driesvints, looks like we have a winner here :)
I'll close the issue when the PR laravel/serializable-closure#87 will be merged.
from framework.
Thanks @shaffe-fr. It's not by consequence that this is related to the enum usages in your PR?
from framework.
Thank you for reporting this issue!
As Laravel is an open source project, we rely on the community to help us diagnose and fix issues as it is not possible to research and fix every issue reported to us via GitHub.
If possible, please make a pull request fixing the issue you have described, along with corresponding tests. All pull requests are promptly reviewed by the Laravel team.
Thank you!
from framework.
I believe this issue is due to the package(laravel/serializable-closure) not supporting the readonly property.
from framework.
@juse-less Could you provide some example codes? I can't reproduce it.
from framework.
@rust17 Hmm.
I might have a different issue entirely, but the behaviour sounds like the same as this issue.
I'll try your fix today, just to be sure I'm not missing something.
I'll then create a minimal reproducer.
from framework.
I tried your fix with the code in the PR #51878 but it does not seems to work.
from framework.
@shaffe-fr Hmm. This looks strange. I tried it and it works for me. You can see the results here. Could you consider accepting this PR? Try to trigger the GitHub Action and check if there are the same errors.
from framework.
Related Issues (20)
- Migration is not working as expected (as written in docs) HOT 5
- Potential infinite recursion when executing `schema:dump` HOT 2
- Potential infinite recursion when executing `schema:dump` HOT 10
- Custom validation rules break generated error MessageBag when custom messages are defined HOT 2
- limit() in relationship load extremely slow in Laravel 11 HOT 2
- Listeners are handled within transactions despite the ShouldHandleEventsAfterCommit interface
- Laravel 11 auto session=database throws intermittent SQLSTATE[08004] [1040] Too many connections error HOT 5
- DatabaseRule "unique" fails quietly when given an incorrect column HOT 3
- Where Query with Arrays for JSON Columns HOT 1
- Adding a batch to a chain through prependToChain/appendToChain results in serialization errors HOT 1
- Cannot override default error page with Laravel 11 Bootstrap Exception Handling HOT 2
- firstOrNew on belongsToMany doesn't work as expected HOT 3
- Accessor date casting formatting as UTC when being serialized to JSON. HOT 1
- Contextual binding resolved when it shouldn't be for LogManager HOT 1
- Using Emergency logging channel throw an exception HOT 3
- Sqlite column processing crashes when column has a "/" in its name
- Database migrations in pretend mode doesn't display insert statements to migrations table
- Job runs longer than "retry_after" will re-run immediately once the "retry after" seconds passed. HOT 1
- Unexpected behaviour when chunking a query HOT 3
- Artisan db:show and db:table fails when database has tables in multiple schemas HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from framework.