laravel-notification-channels / skeleton Goto Github PK

Can we make this repo a Github template?

Please update it in the settings and it'll be easier to fork and work on new projects.

Since this is a template with placeholders like this for example. StyleCI is identifying them as some issues and hence, the repo is getting an X and the first impression of looking at the repo implies there are issues with the project.

1. tried to create a pull request for Adding the possibility to use different sender id;
   However Github took me to Laravel notification

What about support for Laravel 8^

#29

This template needs a overhaul, it's very outdated.

PRs are welcome.

Laravel 8 has been released today and we need to update this repo to support it.
See https://laravel.com/docs/8.x/upgrade & laravel-notification-channels/channels#107

Can we have some basic common tests in this skeleton to make things easier just like other classes?

Just an idea.

cc: @themsaid @freekmurze @mpociot Thoughts?

Right now there are two terms used to describe a notification:

• Notification (obviously) - e.g. CouldNotSendNotification
• Message - e.g. MessageWasSent & SendingMessage

Would it not be better if everything were described as a Notification instead of a Message or a mix of the two?

Support:

• 6.0
• 5.5
• 5.6
• 5.7
• 5.8

Even though 5.6 & 5.7 are out of support, I think we should support them as it's not that difficult.