laravel-enso / data-import Goto Github PK

We should save the issues history also in the 'summary' json.

Error message (and empty table):

You have to add in the main query 'id as "dtRowId"' for the actions to work

Problematic query:
https://github.com/laravel-enso/DataImport/blob/60774e7dcfce34179d1476c44dbc0f7b86fab816/src/app/Tables/Builders/DataImportTable.php#L14-L17

It should be (please note the \" around dtRowId and created_by):

        return DataImport::select(\DB::raw("data_imports.id, data_imports.id as \"dtRowId\", data_imports.type,
                data_imports.original_name, data_imports.comment, data_imports.created_at,
                concat(users.first_name, ' ', users.last_name) as \"created_by\""))
            ->join('users', 'data_imports.created_by', '=', 'users.id');

The tests need to be updated to work after the refactor

Right now the template get instantiated three time during an import cycle and this is not necessary.

This makes the config publishing optional

This is a bug.

Prerequisites

• Are you running the latest version?
• Are you reporting to the correct repository?
• Did you check the documentation?
• Did you perform a cursory search?

Description

See screenshot:

Steps to Reproduce

./vendor/bin/phpunit --filter DataImportTest

This is a bug.

Prerequisites

• Are you running the latest version?
• Are you reporting to the correct repository?
• Did you check the documentation?
• Did you perform a cursory search?

Description

After the latest update to the Data Import package, the field validation fails due to the fact that it no longer converts the table header to snake_case.

Steps to Reproduce

1. Try to import any .xlsx file, having the table headers in Sentance case.

Expected behavior

The validator should convert the table header to snake_case before validating.

Actual behavior

The validator responds with errors, notifying that the snake_cased columns are missing while the Sentence cased columns are extra.

We need an object for the uploaded files.

After creating it we need to update all the dependent packages

• avatarmanager
• documentsmanager
• dataimport

Upload / Delete Template, Download Template and Start Import buttons look bad on smaller displays.

When an import failes with an exception, it remains in status Processing (status = 20 ) and the import cannot be re-attempted even if the application has been updated and the issue resolved.

We should think about a new mechanism - perhaps only available to admins - that resets the import status.

Ensure that the template format is correct

This is a bug.

Prerequisites

• Are you running the latest version?
• Are you reporting to the correct repository?
• Did you check the documentation?
• Did you perform a cursory search?

Description

MaxExecutionTime is being calculated incorrectly

(screenshot of tests passing after setting template->maxExecutionTime to 0)

Steps to Reproduce

1. Run tests with coverage on a regular machine
2. Note a max execution time of 60 being exceeded.

Expected behavior

As none of the individual tests got close to the 60second mark; the tests to just continue

Actual behavior

max execution timeout, roughly 60seconds after the first dataimport test got initialized (so it doesn't seem to reset when being redefined, most likely)

We should check the rest of the package also ...

Hi.
SQL SERVER throws the following exception on the query method of the DataImportTableController

SQLSTATE[42S22]: [Microsoft][ODBC Driver 13 for SQL Server][SQL Server]Invalid column name ' '. (SQL: select top 10 data_imports.id, data_imports.id as dtRowId, data_imports.type, data_imports.original_name, data_imports.comment, data_imports.created_at, concat(users.first_name, " ", users.last_name) as created_by from [data_imports] inner join [users] on [data_imports].[created_by] = [users].[id] where ([data_imports].[original_name] LIKE %% or [data_imports].[created_by] LIKE %% or [data_imports].[created_at] LIKE %%))

Changing the query like below solves the problem.

return DataImport::select(\DB::raw("data_imports.id, data_imports.id as dtRowId, data_imports.type, data_imports.original_name, data_imports.comment, data_imports.created_at, concat(users.first_name, ' ' , users.last_name) as created_by")) ->join('users', 'data_imports.created_by', '=', 'users.id');

This is a feature request.

Prerequisites

• Are you running the latest version?
• Are you reporting to the correct repository?
• Did you check the documentation?
• Did you perform a cursory search?

Description

XML Import - would this be possible to abstract to import different file formats? I'm looking to use with Gramps XML.