langleyfoxall / php-simple-google-maps Goto Github PK

Units tests are required to ensure code functions as expected.

It would be very convenient if you could mutate the time that is calculated, without needing to perform additional processing of the data outside of the package.

Time

If we use the demo as an example, it currently returns the information in seconds. What I propose would do the following.

$journey->duration()->toMinutes()

This would then return, for example, 5 mins. Additional options would also be really handy, e.g. toHours().

Distance

Something similar could also be done to the distance.

$journey->distance()->toMiles()

This package blocks installation for Laravel 7 projects:

langleyfoxall/simple-google-maps v1.0.0 requires laravel/framework ^5.1||^6.0 -> satisfiable by laravel/framework[5.1.x-dev, 5.2.x-dev, 5.3.x-dev, 5.4.x-dev, 5.5.x-dev, 5.6.x-dev, 5.7.x-dev, 5.8.x-dev, 6.x-dev].

This may be as simple as adding ^7.0 to composer.json, but I don't currently have time to test it.

This package is locked to guzzle v 6.x -- Laravel 8 now uses 7.x; there are breaking changes as listed here.

It's also worth noting that guzzle 7.x removes PHP 5 support, and more importantly sets the minimum PHP version to 7.2 -- I have seen dependent packages (laravel-addresses for one) that have the minimum set to 7.1, so upgrading could cause breaking changes for legacy software running on PHP 7.1.

I will look further into this when I get the chance, but I've raised this issue so that it doesn't get forgotten and to welcome input from you other devs.

The Google Directions API has optional parameters that a lot of people would probably want such as waypoints, language and traffic_mode

Perhaps users should be able to pass in an arbitrary array that will be url encoded and added to the request.