I'm a Systems Designer at GitHub working on Primer
Living in San Diego 🌴
I watch a lot of movies, TV series and British panel shows
Talk to me about CSS, design and front-end development on Twitter @KatieLangerman
code academy
I'm a Systems Designer at GitHub working on Primer
Living in San Diego 🌴
I watch a lot of movies, TV series and British panel shows
Talk to me about CSS, design and front-end development on Twitter @KatieLangerman
This was a well written project and it shows through the flawless functionality of your Jammming project.
++ Consistency with indentations and whitespace.
++ Sound code logic.
++ Live search function.
++ All necessary functionalities present.
-- Addition of comments would've been nice.
Overall, an amazing job on this project! Keep it up!
Grade: Exceeds expectation!
I noticed while I was interacting with your project I was getting a lot of console messages regarding unused variables, bad requests, and keyless children.
Although it isn't too big of a deal, it would be a good idea to have these taken care of as they make for a cleaner application.
Good job on keeping consistent with your indentations and whitespace as this made for a organized code structure that was easy to navigate through.
Don't forget that you can place tag attributes each on their own line if they venture too far off to the right. This will make for a list like code structure that assists with legibility.
https://github.com/langermank/jammming/blob/master/src/Components/TrackList/TrackList.js#L12
Grade: Meets expectations
Summary:
Wow I love the screenshots and detail with which you explained your concept.
The addition of the search when pressing enter is a great feature. Initially, when I was reviewing Codecademy's example app, I was surprised to see that pressing enter doesn't allow the search to move through.
You lay out a rock solid plan for implementing a feature that definitely improves the user’s Jammming experience. The idea itself is a natural suggestion, as most users would likely assume the Enter key would serve that purpose and therefore would find it inconvenient that the app doesn’t do that. Your implementation is also the easiest way to accomplish the goal.
I thought the technical design was outstanding with visual cues and detailed instructions on implementation. Caveats were well thought out. Nice work!
Re: the technical design, you could also have a conditional statement within the search method so that the search is only sent when the search box is filled :) We don't want to accidentally trigger a search if it is empty.
Loved the live search function you implemented!
This is a great example of the advantages that come with using React.
Although it's just a simple tweak that changes the boring "click search" functionality to a more responsive "search while you type" option, it makes a world of a difference in terms of user experience!
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.