lancelafontaine / caproomster Goto Github PK

View Code? Open in Web Editor NEW

2.0 2.0 1.0 13.82 MB

CapRoomster is a web application that allows Concordia students to reserve a CAPSTONE room for their projects

Python 78.46% HTML 6.21% JavaScript 11.49% CSS 3.84%

caproomster's People

Contributors

Stargazers

Watchers

Forkers

eeveecc

caproomster's Issues

Create a utility method to create and close database connections

In every TDG method, the db connections are being manually opened and closed with the hardcoded values for our db. Not only is this bad practice, but it is also really inconvenient for our continuous integration builds, since we should be skipping DB interactions for this.

One potential solution would be to create a db utility method that takes a callback function. It could:

open the connection
execute the callback
close the connection

Migrate at least one architectural pattern to an aspect-oriented context

A list of AOP technologies is provided by wikipedia (https://en.wikipedia.org/wiki/Aspect-oriented_
programming#Implementations).

Directory serves no purpose

Object mappers are interacting with Other object’s TDG.

Example: ReservationMapper.find method interacts with RoomTDG, UserTDG, TimeslotTDG.
Solution: Refactor so the mappers interact with other object’s mappers instead. Ex: ReservationMapper interacts with RoomMapper, which uses RoomTDG, etc.

Priority for reservations is given to capstone students.

Assume [...] that there are 5 rooms, available at a 24-hour basis.

You may reserve a maximum of 3 hours a week. If you are already booked for 3 hours, you cannot be placed on a waiting list on any additional reservation. Furthermore, you may not create a repeated reservation for more than 3 weeks.

Deleting a reservation must result in the updating of waitlist/reservations

Update.py in Core is directly interacting with TDG

Ex: Update.updateWaiting calls ReservationTDG.insertDirect and WaitingTDG.delete.
Solution: Make them interact with ReservationMapper, WaitingMapper, which will interact with the TDGs.

There is a (limited) list of equipment which can be made available to any room and which you may request for the room you wish to reserve: computers, projectors, etc. This means that even if the room is available over your desired time slot, you cannot get the room if the requested equipment is not available. You will be placed on a waiting list pending availability of the equipment. Meanwhile, if the room is reserved, then you remain on the waiting list.

New mappers and table in database.
Core business logic and interaction with waiting lists
UI / Front-end work.

There are 5 rooms, available on a 24 hour basis.

checkAvailabilities.py is hard-coded

Find a better way to query a table of room availabilities, instead of recurring to hard-coded logic.

checkModifyAvail(reservations)
checkAvailabilities(date)
validateAvailability(room, date, starttime, endtime)

makeNewReservation endpoint must verify that the user does not already have more than 3 hours reserved per week

Registry interacts with TDGs directly.

Ex: endAction calls RoomTDG.update.
Solution: Make it interact with RoomMapper.

ReservationTDG.update and ReservationTDG.delete are called in ReservationMapper, but code does not exist for these methods.

What happens (on the server side) when one opens a write session on his browser, then closes the browser before the session is completed or timed-out?

Begin preparing REST API endpoints for frontend

Username is not validating in the login screen.

As-is, the system is not comparing the entered username with an existing user name in usertable. It is instead relying on the user typing in the correct userid and password of a certain entry in that table.

views.py index() performs said validation, also get rid of the redundant nested identical return render_template('login.html',error=error)

Setup testing framework + CI + coverage

500 errors being thrown because of database IDs missing

Their SQL script to initialize the database is missing the AUTO_INCREMENT identity on their primary keys. This means that we can't predict specific keys being present in foreign table relations.

Fix issue where days in the calendar are not clickable.

Remove 2-minute lock on room

Arbitrary 2 minute lock on the room will not be required in refactored implementation.
Their implementation is buggy. It often shows that the room is occupied, when it should not be. You can tell when it refuses to accept an reservation, and this is printed on the console:

127.0.0.1 - - [19/Feb/2017 11:51:23] "POST /february/19 HTTP/1.1" 200 -
2016-02-19
[]
Room Occupied

Decouple front-end / back-end code

Just as was done for SOEN 343, we should remove all templating that the previous team used, and reimplement the front end. This allows us to use any technologies we like on the front-end, and also lets our server run purely as a REST API that can be consumed by any client.

The TDG Objects are aware of the Objects that they represent.

example: ReservationTDG insert method accepts a reservation as input. TDGs are supposed to accept only ,Lists, Arrays or Sets of data.