lamenezes / certificator Goto Github PK

Currently it's only possible to use the certificator command to generate certificate for meetup events. It would be nice to have something as:

$ certificator --meta my_meta.json --data my_data.csv --template_path ./my_template.html

There are some methods called get_foo(). They don't receive any arguments (except for self) and could be a property. Also some of these values won't change so could be a cached_property, e.g:

class BaseCertificator:
    def  get_meta(self):
        ... 

could be:

class BaseCertificator:
    @property
    def meta(self):
        ...

WeasyPrint has been fully released since the last commit to master. Now, it requires an updated version of Cairo, which is not available by just apt upgrading in Ubuntu 16. Also, it requires installing libcairo2-dev package, and I think this might be an unnecessary burden to users

My suggestion would be to update requirements.txt to make WeasyPrint install the version we used before

weasyprint==0.42.3

Do you think using an outdate version of it would be bad?

Thanks!

Similar to Meetup [1], but using Eventbrite API.

[1] https://github.com/lamenezes/certificator/tree/master/certificator/meetup

It would be good to the API user have access to the generated certificates (html). This can be done by having a private attribute on BaseCertificator or returning the list to the generate method.

I don't know which approach is better, but those seems good enough for now.

Currently metadata about the event (such as title, venue etc.) are read from a json file. It would be nice if it was possible to also be able to pass it as a python dict:

meta = {'title': 'my event', 'venue': "mother's joana house"}
certificator = CSVCertificator(meta=meta)  # uses meta instead of the content of meta.json file
certificator.generate()